From: Jens Axboe <axboe@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, bunk@stusta.de,
erich@areca.com.tw
Subject: Re: areca-raid-linux-scsi-driver.patch added to -mm tree
Date: Fri, 5 Aug 2005 12:01:54 +0200 [thread overview]
Message-ID: <20050805100153.GJ5561@suse.de> (raw)
In-Reply-To: <1123235067.3239.43.camel@laptopd505.fenrus.org>
On Fri, Aug 05 2005, Arjan van de Ven wrote:
> > +
> > + while (1) {
> > + int64_t span4G, length0;
> > + PSG64ENTRY pdma_sg = (PSG64ENTRY) psge;
> > +
> > + span4G =
> > + (int64_t) address_lo + tmplength;
> > + pdma_sg->addresshigh = address_hi;
> > + pdma_sg->address = address_lo;
> > + if (span4G > 0x100000000ULL) {
> > + /*see if cross 4G boundary */
>
> the linux block layer will guarantee that that doesn't happen afaik
yes, it even does it by default. so that code can be removed.
I agree with the other suggestions made.
--
Jens Axboe
prev parent reply other threads:[~2005-08-05 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200508050912.j759CfQp004898@shell0.pdx.osdl.net>
2005-08-05 9:44 ` areca-raid-linux-scsi-driver.patch added to -mm tree Arjan van de Ven
2005-08-05 10:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805100153.GJ5561@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=erich@areca.com.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox