From: Con Kolivas <kernel@kolivas.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] no-idle-hz aka dynamic ticks-2
Date: Fri, 5 Aug 2005 10:02:17 +1000 [thread overview]
Message-ID: <200508051002.17344.kernel@kolivas.org> (raw)
In-Reply-To: <20050803210915.GA11196@elf.ucw.cz>
On Thu, 4 Aug 2005 07:09 am, Pavel Machek wrote:
> Hi!
>
> > > > As promised, here is an updated patch for the newly released
> > > > 2.6.13-rc5. Boots and runs fine on P4HT (SMP+SMT kernel) built with
> > > > gcc 4.0.1.
> > >
> > > Doesn't compile for me w/ gcc 3.4.4:
> >
> > Thanks for the report. Tiny change required. Here is a respun patch.
>
> I'm not sure if you added them, but...
>
> CC arch/i386/kernel/timers/timer_tsc.o
> arch/i386/kernel/timers/timer_tsc.c: In function `mark_offset_tsc':
> arch/i386/kernel/timers/timer_tsc.c:345: warning: `lost' might be used
> uninitialized in this function arch/i386/kernel/timers/timer_tsc.c:345:
> warning: `delay' might be used uninitialized in this function
> arch/i386/kernel/timers/timer_tsc.c:347: warning: `count' might be used
> uninitialized in this function
Indeed the goto will bypass the setting of these variables and they will be
uninitialised. Will fix with next version, thanks.
Con
next prev parent reply other threads:[~2005-08-05 0:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-02 12:25 [PATCH] no-idle-hz aka dynamic ticks Con Kolivas
2005-08-02 12:58 ` Prakash Punnoor
2005-08-02 13:00 ` Con Kolivas
2005-08-02 13:28 ` [PATCH] no-idle-hz aka dynamic ticks-2 Con Kolivas
2005-08-03 21:09 ` Pavel Machek
2005-08-05 0:02 ` Con Kolivas [this message]
2005-08-05 0:05 ` Con Kolivas
2005-08-05 0:23 ` [PATCH] dyn-tick3 tweaks Con Kolivas
2005-08-05 0:53 ` Nick Piggin
2005-08-05 1:39 ` Con Kolivas
2005-08-05 3:20 ` [PATCH] dyn-tick3 tweaks respin Con Kolivas
2005-08-05 3:32 ` Nick Piggin
2005-08-03 21:12 ` [PATCH] no-idle-hz aka dynamic ticks-2 Pavel Machek
2005-08-04 21:20 ` Con Kolivas
2005-08-03 21:27 ` Pavel Machek
2005-08-03 7:59 ` [PATCH] no-idle-hz aka dynamic ticks Russell King
2005-08-03 9:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508051002.17344.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox