From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262787AbVHEAJX (ORCPT ); Thu, 4 Aug 2005 20:09:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262788AbVHEAJX (ORCPT ); Thu, 4 Aug 2005 20:09:23 -0400 Received: from mail05.syd.optusnet.com.au ([211.29.132.186]:3554 "EHLO mail05.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S262787AbVHEAJV (ORCPT ); Thu, 4 Aug 2005 20:09:21 -0400 From: Con Kolivas To: Pavel Machek Subject: Re: [PATCH] no-idle-hz aka dynamic ticks-2 Date: Fri, 5 Aug 2005 10:05:27 +1000 User-Agent: KMail/1.8.1 Cc: kernel list References: <200508022225.31429.kernel@kolivas.org> <20050803210915.GA11196@elf.ucw.cz> <200508051002.17344.kernel@kolivas.org> In-Reply-To: <200508051002.17344.kernel@kolivas.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200508051005.27162.kernel@kolivas.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Aug 2005 10:02 am, Con Kolivas wrote: > On Thu, 4 Aug 2005 07:09 am, Pavel Machek wrote: > > Hi! > > > > > > > As promised, here is an updated patch for the newly released > > > > > 2.6.13-rc5. Boots and runs fine on P4HT (SMP+SMT kernel) built with > > > > > gcc 4.0.1. > > > > > > > > Doesn't compile for me w/ gcc 3.4.4: > > > > > > Thanks for the report. Tiny change required. Here is a respun patch. > > > > I'm not sure if you added them, but... > > > > CC arch/i386/kernel/timers/timer_tsc.o > > arch/i386/kernel/timers/timer_tsc.c: In function `mark_offset_tsc': > > arch/i386/kernel/timers/timer_tsc.c:345: warning: `lost' might be used > > uninitialized in this function arch/i386/kernel/timers/timer_tsc.c:345: > > warning: `delay' might be used uninitialized in this function > > arch/i386/kernel/timers/timer_tsc.c:347: warning: `count' might be used > > uninitialized in this function > > Indeed the goto will bypass the setting of these variables and they will be > uninitialised. Will fix with next version, thanks. Looking yet further into this, if it gotos monotonic_base it will return without using any of these variables so it's a harmless warning but we may as well initialise them to quieten it. Cheers, Con