From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262941AbVHETxI (ORCPT ); Fri, 5 Aug 2005 15:53:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263085AbVHETxC (ORCPT ); Fri, 5 Aug 2005 15:53:02 -0400 Received: from mx1.redhat.com ([66.187.233.31]:51096 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262941AbVHETwO (ORCPT ); Fri, 5 Aug 2005 15:52:14 -0400 Date: Fri, 5 Aug 2005 15:51:23 -0400 From: Dave Jones To: Kristen Accardi Cc: pcihpd-discuss@lists.sourceforge.net, linux-kernel@vger.kernel.org, greg@kroah.com, rajesh.shah@intel.com Subject: Re: [PATCH] use bus_slot number for name Message-ID: <20050805195123.GN2241@redhat.com> Mail-Followup-To: Dave Jones , Kristen Accardi , pcihpd-discuss@lists.sourceforge.net, linux-kernel@vger.kernel.org, greg@kroah.com, rajesh.shah@intel.com References: <1123269366.8917.39.camel@whizzy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1123269366.8917.39.camel@whizzy> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2005 at 12:16:06PM -0700, Kristen Accardi wrote: > For systems with multiple hotplug controllers, you need to use more than > just the slot number to uniquely name the slot. Without a unique slot > name, the pci_hp_register() will fail. This patch adds the bus number > to the name. > > Signed-off-by: Kristen Carlson Accardi > > diff -uprN -X linux-2.6.13-rc4/Documentation/dontdiff linux-2.6.13-rc4/drivers/pci/hotplug/pciehp.h linux-2.6.13-rc4-shpchp-slot-name-fix/drivers/pci/hotplug/pciehp.h > --- linux-2.6.13-rc4/drivers/pci/hotplug/pciehp.h 2005-07-28 15:44:44.000000000 -0700 > +++ linux-2.6.13-rc4-shpchp-slot-name-fix/drivers/pci/hotplug/pciehp.h 2005-08-04 17:57:18.000000000 -0700 > @@ -302,7 +302,7 @@ static inline void return_resource(struc > > static inline void make_slot_name(char *buffer, int buffer_size, struct slot *slot) > { > - snprintf(buffer, buffer_size, "%d", slot->number); > + snprintf(buffer, buffer_size, "%04d_%04d", slot->bus, slot->number); > } Won't using.. snprintf(buffer, buffer_size, "%s", pci_name(slot)); work equally as well, and also future-proof this ? Dave