From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Adam Litke'" <agl@us.ibm.com>, <linux-kernel@vger.kernel.org>
Cc: <ak@suse.de>, <christoph@lameter.com>, <dwg@au1.ibm.com>
Subject: RE: [RFC] Demand faulting for large pages
Date: Fri, 5 Aug 2005 14:33:41 -0700 [thread overview]
Message-ID: <200508052133.j75LXig31835@unix-os.sc.intel.com> (raw)
In-Reply-To: <1123255298.3121.46.camel@localhost.localdomain>
Adam Litke wrote on Friday, August 05, 2005 8:22 AM
> +int hugetlb_pte_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> + unsigned long address, int write_access)
> +{
> + int ret = VM_FAULT_MINOR;
> + unsigned long idx;
> + pte_t *pte;
> + struct page *page;
> + struct address_space *mapping;
> +
> + WARN_ON(!is_vm_hugetlb_page(vma));
Spurious WARN_ON. Calls to hugetlb_pte_fault() is conditioned upon
if (is_vm_hugetlb_page(vma))
> +int hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> + unsigned long address, int write_access)
> +{
> + ....
> + if (pte_none(*ptep))
> + rc = hugetlb_pte_fault(mm, vma, address, write_access);
> +}
Broken here. Return VM_FAULT_SIGBUS when *pte is present?? Why
can't you move all the logic into hugetlb_pte_fault and simply call
it directly from handle_mm_fault?
next prev parent reply other threads:[~2005-08-05 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 15:21 [RFC] Demand faulting for large pages Adam Litke
2005-08-05 15:53 ` Andi Kleen
2005-08-05 16:37 ` Adam Litke
2005-08-05 16:47 ` Andi Kleen
2005-08-05 17:00 ` Adam Litke
2005-08-05 17:12 ` Andi Kleen
2005-08-05 17:09 ` Christoph Lameter
2005-08-05 21:05 ` Chen, Kenneth W
2005-08-05 21:35 ` Andi Kleen
2005-08-05 21:33 ` Chen, Kenneth W [this message]
2005-08-05 22:05 ` Chen, Kenneth W
2005-08-08 22:16 ` Adam Litke
2005-08-08 22:36 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508052133.j75LXig31835@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=agl@us.ibm.com \
--cc=ak@suse.de \
--cc=christoph@lameter.com \
--cc=dwg@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox