From: Andi Kleen <ak@suse.de>
To: Matt Mackall <mpm@selenic.com>
Cc: Andi Kleen <ak@suse.de>, John B?ckstrand <sandos@home.se>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: lockups with netconsole on e1000 on media insertion
Date: Fri, 5 Aug 2005 23:56:50 +0200 [thread overview]
Message-ID: <20050805215650.GH8266@wotan.suse.de> (raw)
In-Reply-To: <20050805201215.GG7425@waste.org>
> I still don't like this fix. Yes, you're right, it should eventually
> give up. But here it gives up way too easily - 5 could easily
> translate to 5 microseconds. This is analogous to giving up on serial
> transmit if CTS is down for 5 loops.
>
> I'd be much happier if there were some udelay or the like in here so
> that we're not giving up on such a short timeframe.
Problem is that it could translate to a long aggregate delay
e.g. when the kernel tries to dump the backlog after console_init.
That is why I made the delay so short.
Longer delay would be possible, but then it would need some logic
to detect down links and don't delay on them and then retry later etc.
Would be all far more complicated.
-Andi
next prev parent reply other threads:[~2005-08-05 22:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <42F347D2.7000207@home.se.suse.lists.linux.kernel>
2005-08-05 11:45 ` lockups with netconsole on e1000 on media insertion Andi Kleen
2005-08-05 12:44 ` John Bäckstrand
2005-08-05 13:49 ` Steven Rostedt
2005-08-05 13:55 ` Andi Kleen
2005-08-05 14:10 ` Steven Rostedt
2005-08-05 14:14 ` Andi Kleen
2005-08-05 14:27 ` Steven Rostedt
2005-08-05 14:36 ` David S. Miller
2005-08-05 15:02 ` Steven Rostedt
2005-08-05 14:36 ` [PATCH] netpoll can lock up on low memory Steven Rostedt
2005-08-05 20:01 ` Matt Mackall
2005-08-05 20:57 ` Steven Rostedt
2005-08-05 21:28 ` Matt Mackall
2005-08-06 0:23 ` Steven Rostedt
2005-08-06 1:53 ` Matt Mackall
2005-08-06 2:32 ` Steven Rostedt
2005-08-06 7:30 ` Daniel Phillips
2005-08-06 7:58 ` Ingo Molnar
2005-08-06 23:10 ` Matt Mackall
2005-08-06 9:46 ` David S. Miller
2005-08-06 9:57 ` Steven Rostedt
2005-08-06 12:09 ` John Bäckstrand
2005-08-07 5:40 ` Matt Mackall
2005-08-05 21:26 ` Andi Kleen
2005-08-05 21:42 ` Matt Mackall
2005-08-05 21:51 ` Andi Kleen
2005-08-06 1:16 ` Matt Mackall
2005-08-06 0:30 ` Steven Rostedt
2005-08-06 7:45 ` Ingo Molnar
2005-08-06 11:29 ` Andi Kleen
2005-08-07 21:12 ` lockups with netconsole on e1000 on media insertion John Bäckstrand
2005-08-08 2:29 ` Steven Rostedt
2005-08-05 20:12 ` Matt Mackall
2005-08-05 21:56 ` Andi Kleen [this message]
2005-08-05 23:20 ` Matt Mackall
2005-08-05 23:51 ` Andi Kleen
2005-08-06 1:22 ` Matt Mackall
2005-08-06 1:37 ` Daniel Phillips
2005-08-05 11:04 John Bäckstrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805215650.GH8266@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=sandos@home.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox