From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbVHGSXP (ORCPT ); Sun, 7 Aug 2005 14:23:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752511AbVHGSXP (ORCPT ); Sun, 7 Aug 2005 14:23:15 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:45829 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1752510AbVHGSXP (ORCPT ); Sun, 7 Aug 2005 14:23:15 -0400 Date: Sun, 7 Aug 2005 20:23:12 +0200 From: Adrian Bunk To: "Martin J. Bligh" Cc: linux-kernel Subject: Re: EXPORT_SYMBOL generates "is deprecated" noise Message-ID: <20050807182312.GG3513@stusta.de> References: <251790000.1123438079@[10.10.2.4]> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <251790000.1123438079@[10.10.2.4]> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 07, 2005 at 11:07:59AM -0700, Martin J. Bligh wrote: > I'm getting lots of errors like this nowadays: > > drivers/serial/8250.c:2651: warning: `register_serial' is deprecated > (declared at drivers/serial/8250.c:2607) > > Which is just: "EXPORT_SYMBOL(register_serial);" > > Sorry, but that's just compile-time noise, not anything useful. > Warning on real usages of it might be handy (we can go fix the users) > but not EXPORT_SYMBOL - we can't kill the export until the function > goes away. The more noise we have, the harder it is to see real errors > and warnings. > > I took a quick poke around, but can't see what generates this stuff. > What is doing these checks, and can we please make an exception for > EXPORT_SYMBOL (and EXPORT_SYMBOL_GPL) somehow? This is generated by the __deprecated marker (#define'd to __attribute__((deprecated)) ) at the prototype in include/linux/serial.h. You could somehow #ifdef the warning away, but IMHO this would be more ugly than living with the warning until the last user is gone. > M. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed