From: Adrian Bunk <bunk@stusta.de>
To: "Martin J. Bligh" <mbligh@mbligh.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: EXPORT_SYMBOL generates "is deprecated" noise
Date: Sun, 7 Aug 2005 21:06:11 +0200 [thread overview]
Message-ID: <20050807190611.GH3513@stusta.de> (raw)
In-Reply-To: <255090000.1123440916@[10.10.2.4]>
On Sun, Aug 07, 2005 at 11:55:16AM -0700, Martin J. Bligh wrote:
>
>
> --Adrian Bunk <bunk@stusta.de> wrote (on Sunday, August 07, 2005 20:23:12 +0200):
>
> > On Sun, Aug 07, 2005 at 11:07:59AM -0700, Martin J. Bligh wrote:
> >> I'm getting lots of errors like this nowadays:
> >>
> >> drivers/serial/8250.c:2651: warning: `register_serial' is deprecated
> >> (declared at drivers/serial/8250.c:2607)
> >>
> >> Which is just: "EXPORT_SYMBOL(register_serial);"
> >>
> >> Sorry, but that's just compile-time noise, not anything useful.
> >> Warning on real usages of it might be handy (we can go fix the users)
> >> but not EXPORT_SYMBOL - we can't kill the export until the function
> >> goes away. The more noise we have, the harder it is to see real errors
> >> and warnings.
> >>
> >> I took a quick poke around, but can't see what generates this stuff.
> >> What is doing these checks, and can we please make an exception for
> >> EXPORT_SYMBOL (and EXPORT_SYMBOL_GPL) somehow?
> >
> > This is generated by the __deprecated marker (#define'd to
> > __attribute__((deprecated)) ) at the prototype in
> > include/linux/serial.h.
> >
> > You could somehow #ifdef the warning away, but IMHO this would be more
> > ugly than living with the warning until the last user is gone.
>
> If it's going to spout crap when I'm not even using the deprecated
> function, it's worse than useless, I'm afraid.
>...
It's reminding us that we are still offering a deprecated function. ;-)
> M.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-08-07 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-07 18:07 EXPORT_SYMBOL generates "is deprecated" noise Martin J. Bligh
2005-08-07 18:23 ` Adrian Bunk
2005-08-07 18:55 ` Martin J. Bligh
2005-08-07 19:06 ` Adrian Bunk [this message]
2005-08-07 19:13 ` Martin J. Bligh
2005-08-07 18:26 ` Martin J. Bligh
2005-08-08 13:46 ` Arnd Bergmann
2005-08-07 19:15 ` Russell King
2005-08-08 6:28 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050807190611.GH3513@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox