[PATCH] Export handle_mm_fault to modules.

[PATCH] Export handle_mm_fault to modules.

[Stelian Pop]

handle_mm_fault changed from an inline function to a non-inline one
(__handle_mm_fault), which is not available to external kernel modules.
The patch below fixes this.

Stelian.

Export __handle_mm_fault to modules (called by the inlined handle_mm_fault function).

Signed-off-by: Stelian Pop <stelian@popies.net>

Index: linux-2.6.git/mm/memory.c
===================================================================
--- linux-2.6.git.orig/mm/memory.c	2005-08-05 22:26:20.000000000 +0200
+++ linux-2.6.git/mm/memory.c	2005-08-05 23:46:49.000000000 +0200
@@ -2061,6 +2061,7 @@
 	spin_unlock(&mm->page_table_lock);
 	return VM_FAULT_OOM;
 }
+EXPORT_SYMBOL(__handle_mm_fault);
 
 #ifndef __PAGETABLE_PUD_FOLDED
 /*

-- 
Stelian Pop <stelian@popies.net>

Re: [PATCH] Export handle_mm_fault to modules.

[Dave Jones]

On Fri, Aug 05, 2005 at 11:55:12PM +0200, Stelian Pop wrote:
 > handle_mm_fault changed from an inline function to a non-inline one
 > (__handle_mm_fault), which is not available to external kernel modules.
 > The patch below fixes this.
 > 
 > Stelian.
 > 
 > Export __handle_mm_fault to modules (called by the inlined handle_mm_fault function).

Which modules need this ?

		Dave

Re: [PATCH] Export handle_mm_fault to modules.

[Linus Torvalds]

On Fri, 5 Aug 2005, Stelian Pop wrote:
>
> handle_mm_fault changed from an inline function to a non-inline one
> (__handle_mm_fault), which is not available to external kernel modules.
> The patch below fixes this.

We didn't use to export handle_mm_fault before, and it wasn't an inline 
function in 2.6.12 either. 

And no modules I know of call handle_mm_fault(). What module causes 
problems? That's very much a kernel internal function.

IOW, there's something wrong in your setup. It can't have worked on 2.6.12 
either, 

The only thing that has ever exported it afaik is

	arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */

and that looks pretty suspicious too (what is MOL, and regardless, 
shouldn't it be an EXPORT_SYMBOL_GPL?).

		Linus

Re: [PATCH] Export handle_mm_fault to modules.

[Olof Johansson]

On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote:

> The only thing that has ever exported it afaik is
> 
> 	arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> 
> and that looks pretty suspicious too (what is MOL, and regardless, 
> shouldn't it be an EXPORT_SYMBOL_GPL?).

Mac-on-Linux, see http://www.maconlinux.org/. Run MacOS in a virtualized
machine under Linux (or the other way around). It's GPL.


-Olof

Re: [PATCH] Export handle_mm_fault to modules.

[Linus Torvalds]

On Fri, 5 Aug 2005, Olof Johansson wrote:
>
> On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote:
> 
> > The only thing that has ever exported it afaik is
> > 
> > 	arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> > 
> > and that looks pretty suspicious too (what is MOL, and regardless, 
> > shouldn't it be an EXPORT_SYMBOL_GPL?).
> 
> Mac-on-Linux, see http://www.maconlinux.org/. Run MacOS in a virtualized
> machine under Linux (or the other way around). It's GPL.

Ok. Then I suspect the right patch is this one. Stelian, can you verify?

		Linus
---
diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
--- a/arch/ppc/kernel/ppc_ksyms.c
+++ b/arch/ppc/kernel/ppc_ksyms.c
@@ -324,7 +324,7 @@ EXPORT_SYMBOL(__res);
 
 EXPORT_SYMBOL(next_mmu_context);
 EXPORT_SYMBOL(set_context);
-EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
+EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
 EXPORT_SYMBOL(disarm_decr);
 #ifdef CONFIG_PPC_STD_MMU
 extern long mol_trampoline;

Re: [PATCH] Export handle_mm_fault to modules.

[Stelian Pop]

Le vendredi 05 août 2005 à 16:43 -0700, Linus Torvalds a écrit :
> 
> On Fri, 5 Aug 2005, Olof Johansson wrote:
> >
> > On Fri, Aug 05, 2005 at 04:02:13PM -0700, Linus Torvalds wrote:
> > 
> > > The only thing that has ever exported it afaik is
> > > 
> > > 	arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> > > 
> > > and that looks pretty suspicious too (what is MOL, and regardless, 
> > > shouldn't it be an EXPORT_SYMBOL_GPL?).
> > 
> > Mac-on-Linux, see http://www.maconlinux.org/. Run MacOS in a virtualized
> > machine under Linux (or the other way around). It's GPL.
> 
> Ok. Then I suspect the right patch is this one. Stelian, can you verify?

I confirm, it works perfectly.

Stelian.

> 
> 		Linus
> ---
> diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
> --- a/arch/ppc/kernel/ppc_ksyms.c
> +++ b/arch/ppc/kernel/ppc_ksyms.c
> @@ -324,7 +324,7 @@ EXPORT_SYMBOL(__res);
>  
>  EXPORT_SYMBOL(next_mmu_context);
>  EXPORT_SYMBOL(set_context);
> -EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> +EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
>  EXPORT_SYMBOL(disarm_decr);
>  #ifdef CONFIG_PPC_STD_MMU
>  extern long mol_trampoline;
> 
-- 
Stelian Pop <stelian@popies.net>

Re: [PATCH] Export handle_mm_fault to modules.

[Arnd Bergmann]

On Sünnavend 06 August 2005 01:43, Linus Torvalds wrote:
> diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
> --- a/arch/ppc/kernel/ppc_ksyms.c
> +++ b/arch/ppc/kernel/ppc_ksyms.c
> @@ -324,7 +324,7 @@ EXPORT_SYMBOL(__res);
>  
>  EXPORT_SYMBOL(next_mmu_context);
>  EXPORT_SYMBOL(set_context);
> -EXPORT_SYMBOL(handle_mm_fault); /* For MOL */
> +EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
>  EXPORT_SYMBOL(disarm_decr);
>  #ifdef CONFIG_PPC_STD_MMU
>  extern long mol_trampoline;

We will need the same export on ppc64 for managing SPEs on the
Cell processor. My current patch removes the export on ppc
and adds a global (*_GPL) one. Should I rather have another
architecture specific export in ppc64?

	Arnd <><

Re: [PATCH] Export handle_mm_fault to modules.

[Linus Torvalds]

On Mon, 8 Aug 2005, Arnd Bergmann wrote:
> 
> We will need the same export on ppc64 for managing SPEs on the
> Cell processor. My current patch removes the export on ppc
> and adds a global (*_GPL) one. Should I rather have another
> architecture specific export in ppc64?

I don't see any reason not to make it global if there are two
architectures that need it. Especially as long as it's marked GPL-only so 
that people don't start misusing it.

		Linus