[PATCH] add MODULE_ALIAS for x86_64 aes

[PATCH] add MODULE_ALIAS for x86_64 aes

[Olaf Hering]

modprobe aes does not work on x86_64. i386 has a similar line,
this could be the right fix. Would be nice to have in 2.6.13 final.

Signed-off-by: Olaf Hering <olh@suse.de>

 arch/x86_64/crypto/aes.c |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6.13-rc6-aes/arch/x86_64/crypto/aes.c
===================================================================
--- linux-2.6.13-rc6-aes.orig/arch/x86_64/crypto/aes.c
+++ linux-2.6.13-rc6-aes/arch/x86_64/crypto/aes.c
@@ -322,3 +322,4 @@ module_exit(aes_fini);
 
 MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("aes");

Re: [PATCH] add MODULE_ALIAS for x86_64 aes

[Andrew Morton]

Olaf Hering <olh@suse.de> wrote:
>
> 
> modprobe aes does not work on x86_64. i386 has a similar line,
> this could be the right fix. Would be nice to have in 2.6.13 final.
> 

What do you mean by "this could be the right fix"?  Did it work?

> 
> Index: linux-2.6.13-rc6-aes/arch/x86_64/crypto/aes.c
> ===================================================================
> --- linux-2.6.13-rc6-aes.orig/arch/x86_64/crypto/aes.c
> +++ linux-2.6.13-rc6-aes/arch/x86_64/crypto/aes.c
> @@ -322,3 +322,4 @@ module_exit(aes_fini);
>  
>  MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("aes");

Re: [PATCH] add MODULE_ALIAS for x86_64 aes

[Olaf Hering]

 On Mon, Aug 08, Andrew Morton wrote:

> Olaf Hering <olh@suse.de> wrote:
> >
> > 
> > modprobe aes does not work on x86_64. i386 has a similar line,
> > this could be the right fix. Would be nice to have in 2.6.13 final.
> > 
> 
> What do you mean by "this could be the right fix"?  Did it work?

I cant test it due to lack of hardware. Will find someone who does.
modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.

Re: [PATCH] add MODULE_ALIAS for x86_64 aes

[Olaf Hering]

 On Mon, Aug 08, Olaf Hering wrote:

>  On Mon, Aug 08, Andrew Morton wrote:
> 
> > Olaf Hering <olh@suse.de> wrote:
> > >
> > > 
> > > modprobe aes does not work on x86_64. i386 has a similar line,
> > > this could be the right fix. Would be nice to have in 2.6.13 final.
> > > 
> > 
> > What do you mean by "this could be the right fix"?  Did it work?
> 
> I cant test it due to lack of hardware. Will find someone who does.
> modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.

This works, tested it. modprobe -v aes
insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko 

Re: [PATCH] add MODULE_ALIAS for x86_64 aes

[James Morris]

On Mon, 8 Aug 2005, Olaf Hering wrote:

>  On Mon, Aug 08, Olaf Hering wrote:
> >  On Mon, Aug 08, Andrew Morton wrote:
> > 
> > > What do you mean by "this could be the right fix"?  Did it work?
> > 
> > I cant test it due to lack of hardware. Will find someone who does.
> > modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.
> 
> This works, tested it. modprobe -v aes
> insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko 

It looks the same as the i386 version, so probably ok.

(CC'd the crypto maintainer).


- James
-- 
James Morris
<jmorris@namei.org>

[AES] Add module alias to x86_64 implementation

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On Tue, Aug 09, 2005 at 12:16:18AM -0400, James Morris wrote:
>
> > > I cant test it due to lack of hardware. Will find someone who does.
> > > modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.
> > 
> > This works, tested it. modprobe -v aes
> > insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko 
> 
> It looks the same as the i386 version, so probably ok.

It looks good to me too.  Andrew, please add this to 2.6.13:

Subject: [AES] Add module alias to x86_64 implementation
From: Olaf Hering <olh@suse.de>

modprobe aes does not work on x86_64. i386 has a similar line,

Signed-off-by: Olaf Hering <olh@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 274 bytes --]

diff --git a/arch/x86_64/crypto/aes.c b/arch/x86_64/crypto/aes.c
--- a/arch/x86_64/crypto/aes.c
+++ b/arch/x86_64/crypto/aes.c
@@ -322,3 +322,4 @@ module_exit(aes_fini);
 
 MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("aes");

Re: [AES] Add module alias to x86_64 implementation

[David S. Miller]

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 11 Aug 2005 22:28:35 +1000

> It looks good to me too.  Andrew, please add this to 2.6.13:

It's already in Linus's tree for a few days now.