public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: obsolete modparam change busted.
Date: Mon, 8 Aug 2005 14:49:55 -0400	[thread overview]
Message-ID: <20050808184955.GA18779@redhat.com> (raw)

Circa 2.6.10, the module loader started barfing if
modprobe.conf contained obsolete parameters.

However this change was broken, and if the modprobe.conf
has trailing whitespace, modules fail to load with the
following helpful message..

snd_intel8x0: Unknown parameter `'

This ends up screwing over people who upgrade from previously
working configurations, so we've been backing out that change
in Fedora for a while with the patch below.

It doesn't look like the right thing to do, but it has got
things working again at least. Probably we should just check
explicity for whitespace and ignore it somewhere else in
the module loader.  Rusty?

		Dave


diff -urNp --exclude-from=/home/davej/.exclude linux-1503/kernel/module.c linux-1700/kernel/module.c
--- linux-1503/kernel/module.c
+++ linux-1700/kernel/module.c
@@ -1707,8 +1707,6 @@ static struct module *load_module(void _
 				 / sizeof(struct kernel_param),
 				 NULL);
 	}
-	if (err < 0)
-		goto arch_cleanup;
 
 	err = mod_sysfs_setup(mod, 
 			      (struct kernel_param *)

             reply	other threads:[~2005-08-08 18:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-08 18:49 Dave Jones [this message]
2005-08-09  4:01 ` obsolete modparam change busted Rusty Russell
2005-08-13 18:27   ` Dave Jones
2005-08-16  4:39     ` Rusty Russell
2005-08-16  5:16       ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050808184955.GA18779@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox