public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: domen@coderock.org
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org,
	Maximilian Attems <janitor@sternwelten.at>,
	domen@coderock.org
Subject: [patch 05/16] fs/dcache.c: list_for_each*
Date: Tue, 09 Aug 2005 00:29:41 +0200	[thread overview]
Message-ID: <20050808223027.564769000@homer> (raw)
In-Reply-To: 20050808222936.090422000@homer

[-- Attachment #1: list-for-each-fs_dcache.patch --]
[-- Type: text/plain, Size: 1790 bytes --]

From: Domen Puncer <domen@coderock.org>



First one is list_for_each_entry (thanks maks), second 2 list_for_each_safe.

Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
 dcache.c |   16 ++++------------
 1 files changed, 4 insertions(+), 12 deletions(-)

Index: quilt/fs/dcache.c
===================================================================
--- quilt.orig/fs/dcache.c
+++ quilt/fs/dcache.c
@@ -335,12 +335,10 @@ struct dentry * d_find_alias(struct inod
  */
 void d_prune_aliases(struct inode *inode)
 {
-	struct list_head *tmp, *head = &inode->i_dentry;
+	struct dentry *dentry;
 restart:
 	spin_lock(&dcache_lock);
-	tmp = head;
-	while ((tmp = tmp->next) != head) {
-		struct dentry *dentry = list_entry(tmp, struct dentry, d_alias);
+	list_for_each_entry(dentry, &inode->i_dentry, d_alias) {
 		spin_lock(&dentry->d_lock);
 		if (!atomic_read(&dentry->d_count)) {
 			__dget_locked(dentry);
@@ -461,10 +459,7 @@ void shrink_dcache_sb(struct super_block
 	 * superblock to the most recent end of the unused list.
 	 */
 	spin_lock(&dcache_lock);
-	next = dentry_unused.next;
-	while (next != &dentry_unused) {
-		tmp = next;
-		next = tmp->next;
+	list_for_each_safe(tmp, next, &dentry_unused) {
 		dentry = list_entry(tmp, struct dentry, d_lru);
 		if (dentry->d_sb != sb)
 			continue;
@@ -476,10 +471,7 @@ void shrink_dcache_sb(struct super_block
 	 * Pass two ... free the dentries for this superblock.
 	 */
 repeat:
-	next = dentry_unused.next;
-	while (next != &dentry_unused) {
-		tmp = next;
-		next = tmp->next;
+	list_for_each_safe(tmp, next, &dentry_unused) {
 		dentry = list_entry(tmp, struct dentry, d_lru);
 		if (dentry->d_sb != sb)
 			continue;

--

  parent reply	other threads:[~2005-08-08 22:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-08 22:29 [patch 00/16] old kernel janitor patches domen
2005-08-08 22:29 ` [patch 01/16] ide: min/max macros in ide-timing.h domen
2005-08-08 22:29 ` [patch 02/16] net/ppp-generic: list_for_each_entry domen
2005-08-08 22:29 ` [patch 03/16] jffs/intrep: list_for_each_entry domen
2005-08-08 22:29 ` [patch 04/16] fs/namespace.c: list_for_each_entry domen
2005-08-08 22:29 ` domen [this message]
2005-08-08 22:29 ` [patch 06/16] ide-tape: replace schedule_timeout() with msleep() domen
2005-08-08 22:29 ` [patch 07/16] block/umem: replace PRINTK with pr_debug domen
2005-08-08 22:29 ` [patch 08/16] tulip/de4x5: list_for_each domen
2005-08-08 22:29 ` [patch 09/16] sh: bigsur/io: minmax-removal domen
2005-08-08 22:29 ` [patch 10/16] sh: hd64465: minmax-removal domen
2005-08-08 22:29 ` [patch 11/16] block/xd: replace schedule_timeout() with msleep()/msleep_interruptible() domen
2005-08-08 22:29 ` [patch 12/16] ide/ide-cs: replace schedule_timeout() with msleep() domen
2005-08-08 22:29 ` [patch 13/16] net/stir4200: replace direct assignment with set_current_state() domen
2005-08-08 22:29 ` [patch 14/16] net/tms380tr: " domen
2005-08-11  3:19   ` Jeff Garzik
2005-08-11  3:27     ` Nishanth Aravamudan
2005-08-08 22:29 ` [patch 15/16] reiserfs: super.c - vfree() checking cleanups domen
2005-08-08 22:29 ` [patch 16/16] block/ps2esdi: replace sleep_on() with wait_event() domen
2005-08-09  6:14   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050808223027.564769000@homer \
    --to=domen@coderock.org \
    --cc=akpm@osdl.org \
    --cc=janitor@sternwelten.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox