From: Adrian Bunk <bunk@stusta.de>
To: Jiri Slaby <jirislaby@gmail.com>, jgarzik@pobox.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
netdev@vger.kernel.org
Subject: [-mm patch] SIS190 must select MII
Date: Tue, 9 Aug 2005 02:41:00 +0200 [thread overview]
Message-ID: <20050809004100.GS4006@stusta.de> (raw)
In-Reply-To: <42F7F837.6080800@gmail.com>
On Tue, Aug 09, 2005 at 02:26:31AM +0200, Jiri Slaby wrote:
> Hello, i find out this problem:
> #make O=../bu allmodconfig
> ...
> #make O=../bu all
> ...
> LD .tmp_vmlinux1
> drivers/built-in.o(.text+0x63c87): In function `sis190_get_settings':
> /l/latest/xxx/drivers/net/sis190.c:1656: undefined reference to
> `mii_ethtool_gset'
>...
Obvious bug in git-netdev-sis190.patch, fix below.
cu
Adrian
<-- snip -->
SIS190 must select MII since it's using it.
While I was editing the Kconfig entry, I also converted the spaces to
tabs.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc5-mm1-full/drivers/net/Kconfig.old 2005-08-09 02:32:14.000000000 +0200
+++ linux-2.6.13-rc5-mm1-full/drivers/net/Kconfig 2005-08-09 02:33:12.000000000 +0200
@@ -1924,14 +1924,15 @@
If in doubt, say Y.
config SIS190
- tristate "SiS190 gigabit ethernet support"
- depends on PCI
- select CRC32
- ---help---
- Say Y here if you have a SiS 190 PCI Gigabit Ethernet adapter.
+ tristate "SiS190 gigabit ethernet support"
+ depends on PCI
+ select CRC32
+ select MII
+ ---help---
+ Say Y here if you have a SiS 190 PCI Gigabit Ethernet adapter.
- To compile this driver as a module, choose M here: the module
- will be called sis190. This is recommended.
+ To compile this driver as a module, choose M here: the module
+ will be called sis190. This is recommended.
config SKGE
tristate "New SysKonnect GigaEthernet support (EXPERIMENTAL)"
prev parent reply other threads:[~2005-08-09 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-09 0:26 2.6.13-rc5-mm1, mii.c functions linking problem Jiri Slaby
2005-08-09 0:41 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050809004100.GS4006@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox