From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Yang Yi <yang.yi@bmrtech.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] latency logger for realtime-preempt-2.6.12-final-V0.7.51-30
Date: Thu, 11 Aug 2005 13:33:36 +0200 [thread overview]
Message-ID: <20050811113336.GA22591@elte.hu> (raw)
In-Reply-To: <1123724676.8187.17.camel@dhcp153.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> On Thu, 2005-08-04 at 15:52 +0200, Ingo Molnar wrote:
>
> > would be nice to clean up the impact of the latency-histogram code some
> > more though: e.g. the #ifdef jungle check_critical_timing() is
> > disgusting. Could be cleaned up by always recording the latency_type
> > being currently traced into a new tr->latency_type field, and then using
> > that in check_critical_timing().
>
> the code appears to be adding ifdefs to make preempt_max_latency work
> like preempt_threshold , I think all the nasty ifdefs could go away if
> we just made it use preempt_threshold .. Plus it logs latency during
> boot up cause preempt_max_latency equals zero .
yes. Would be nice to have these cleanups too. The #ifdef impact of the
LATENCY_HIST code is quite high at the moment, and it needs to be
decreased.
Ingo
next prev parent reply other threads:[~2005-08-11 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-03 4:19 [PATCH] latency logger for realtime-preempt-2.6.12-final-V0.7.51-30 Yang Yi
2005-08-04 13:52 ` Ingo Molnar
2005-08-11 1:44 ` Daniel Walker
2005-08-11 11:33 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-15 10:02 yangyi
2005-07-16 17:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050811113336.GA22591@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.yi@bmrtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox