public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] (2/7) I2C: Kill i2c_algorithm.id
Date: Thu, 11 Aug 2005 23:36:49 +0200	[thread overview]
Message-ID: <20050811233649.472cfa05.khali@linux-fr.org> (raw)
In-Reply-To: <20050811231828.3e7f5837.khali@linux-fr.org>

Use the adapter id rather than the algorithm id to detect the i2c-isa
pseudo-adapter. This saves one level of dereferencing, and the
algorithm ids will soon be gone anyway.

Signed-off-by: Jean Delvare <khali@linux-fr.org>

 drivers/i2c/busses/i2c-isa.c |    1 +
 include/linux/i2c-isa.h      |    6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

--- linux-2.6.13-rc5.orig/drivers/i2c/busses/i2c-isa.c	2005-08-02 20:30:04.000000000 +0200
+++ linux-2.6.13-rc5/drivers/i2c/busses/i2c-isa.c	2005-08-02 20:30:24.000000000 +0200
@@ -50,6 +50,7 @@
 /* There can only be one... */
 static struct i2c_adapter isa_adapter = {
 	.owner		= THIS_MODULE,
+	.id		= I2C_ALGO_ISA | I2C_HW_ISA,
 	.class          = I2C_CLASS_HWMON,
 	.algo		= &isa_algorithm,
 	.name		= "ISA main adapter",
--- linux-2.6.13-rc5.orig/include/linux/i2c-isa.h	2005-08-02 20:30:04.000000000 +0200
+++ linux-2.6.13-rc5/include/linux/i2c-isa.h	2005-08-02 20:30:24.000000000 +0200
@@ -28,9 +28,9 @@
 
 /* Detect whether we are on the isa bus. This is only useful to hybrid
    (i2c+isa) drivers. */
-#define i2c_is_isa_client(clientptr) \
-        ((clientptr)->adapter->algo->id == I2C_ALGO_ISA)
 #define i2c_is_isa_adapter(adapptr) \
-        ((adapptr)->algo->id == I2C_ALGO_ISA)
+        ((adapptr)->id == (I2C_ALGO_ISA | I2C_HW_ISA))
+#define i2c_is_isa_client(clientptr) \
+        i2c_is_isa_adapter((clientptr)->adapter)
 
 #endif /* _LINUX_I2C_ISA_H */

-- 
Jean Delvare

  parent reply	other threads:[~2005-08-11 21:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-11 21:18 [PATCH] (0/7) I2C: Kill i2c_algorithm.{name,id} Jean Delvare
2005-08-11 21:33 ` [PATCH] (1/7) I2C: Kill i2c_algorithm.name Jean Delvare
2005-08-11 21:36 ` Jean Delvare [this message]
2005-08-11 21:38 ` [PATCH] (3/7) I2C: Kill i2c_algorithm.id Jean Delvare
2005-08-11 21:40 ` [PATCH] (4/7) " Jean Delvare
2005-08-11 21:41 ` [PATCH] (5/7) " Jean Delvare
2005-08-11 21:51 ` [PATCH] (6/7) " Jean Delvare
2005-08-11 21:52 ` [PATCH] (7/7) " Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050811233649.472cfa05.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox