From: Dave Jones <davej@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: David Mosberger <davidm@napali.hpl.hp.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: suspect code in drivers/char/agp/generic.c
Date: Thu, 11 Aug 2005 23:28:08 -0400 [thread overview]
Message-ID: <20050812032808.GE9529@redhat.com> (raw)
In-Reply-To: <42FBF62F.5090205@goop.org>
On Thu, Aug 11, 2005 at 06:06:55PM -0700, Jeremy Fitzhardinge wrote:
> I was just looking at agp_copy_info(), which contains this code:
>
> 318 if (bridge->mode & AGPSTAT_MODE_3_0)
> 319 info->mode = bridge->mode & ~AGP3_RESERVED_MASK;
> 320 else
> 321 info->mode = bridge->mode & ~AGP2_RESERVED_MASK;
> 322 info->mode = bridge->mode;
>
> This looks wrong to me, since line 322 overrides the previous 4 lines'
> work...
>
> I have no idea whether this is actually causing a problem, but I'd
> thought I'd call attention to it.
Ugh, that crept in when the multiple gart support got added.
Line 322 shouldn't be there. I'll nuke it in agpgart.git
Whilst its clearly wrong, I'd like the corrected version to take a quick
spin in -mm before we add this to 2.6.13, just in case.
Dave
prev parent reply other threads:[~2005-08-12 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 1:06 suspect code in drivers/char/agp/generic.c Jeremy Fitzhardinge
2005-08-12 3:28 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050812032808.GE9529@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=davidm@napali.hpl.hp.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox