From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Andi Kleen <ak@suse.de>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Martin Wilck <martin.wilck@fujitsu-siemens.com>,
linux-kernel@vger.kernel.org
Subject: Re: APIC version and 8-bit APIC IDs
Date: Fri, 12 Aug 2005 11:40:33 -0700 [thread overview]
Message-ID: <20050812114033.B15541@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050812182228.GE22901@wotan.suse.de>; from ak@suse.de on Fri, Aug 12, 2005 at 08:22:28PM +0200
On Fri, Aug 12, 2005 at 08:22:28PM +0200, Andi Kleen wrote:
> > --- linux-2.6.13-rc6/arch/x86_64/kernel/mpparse.c~ 2005-08-12 10:19:07.037696416 -0700
> > +++ linux-2.6.13-rc6/arch/x86_64/kernel/mpparse.c 2005-08-12 10:19:38.098974384 -0700
> > @@ -707,7 +707,7 @@
> >
> > processor.mpc_type = MP_PROCESSOR;
> > processor.mpc_apicid = id;
> > - processor.mpc_apicver = 0x10; /* TBD: lapic version */
> > + processor.mpc_apicver = GET_APIC_VERSION(apic_read(APIC_LVR));
>
> That code executes on the BP. What happens when different CPUs have
> different APIC versions? Not sure if that can happen, but it
> still looks a bit like "cheating.
Not sure if we ever support CPUs with different APIC versions. That will
probably require some ACPI SPEC changes too..
I would say, for now just follow the i386 code.
thanks,
suresh
next prev parent reply other threads:[~2005-08-12 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <42FC8461.2040102@fujitsu-siemens.com.suse.lists.linux.kernel>
2005-08-12 11:43 ` APIC version and 8-bit APIC IDs Andi Kleen
2005-08-12 13:21 ` Martin Wilck
2005-08-12 13:32 ` Andi Kleen
2005-08-12 13:51 ` Martin Wilck
2005-08-12 14:55 ` Martin Wilck
2005-08-12 14:57 ` Andi Kleen
2005-08-12 16:37 ` yhlu
2005-08-12 16:42 ` Andi Kleen
2005-08-12 17:44 ` yhlu
2005-08-22 9:50 ` Martin Wilck
2005-08-23 11:10 ` Maciej W. Rozycki
2005-08-26 14:01 ` Martin Wilck
2005-08-26 14:50 ` Maciej W. Rozycki
2005-08-29 7:25 ` Martin Wilck
2005-08-12 18:19 ` Siddha, Suresh B
2005-08-12 18:22 ` Andi Kleen
2005-08-12 18:40 ` Siddha, Suresh B [this message]
2005-08-12 18:50 ` Andi Kleen
2005-08-31 13:13 ` Martin Wilck
2005-08-31 13:25 ` Maciej W. Rozycki
2005-08-31 14:27 ` Martin Wilck
[not found] ` <4315B2D9.6080700@fujitsu-siemens.com>
[not found] ` <Pine.LNX.4.61L.0508311450020.10940@blysk.ds.pg.gda.pl>
2005-08-31 14:50 ` Martin Wilck
2005-08-31 14:40 ` Andi Kleen
2005-08-12 11:13 Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050812114033.B15541@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.wilck@fujitsu-siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox