* [PATCH] kernel spams syslog every 10 sec with w1 debug
@ 2005-08-12 15:07 Olaf Hering
2005-08-12 15:37 ` Evgeniy Polyakov
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2005-08-12 15:07 UTC (permalink / raw)
To: linux-kernel, Andrew Morton, johnpol
Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.
After installing 10.0 B1, I found this in my syslog:
Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
Signed-off-by: Olaf Hering <olh@suse.de>
drivers/w1/w1.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.13-rc6-aes/drivers/w1/w1.c
===================================================================
--- linux-2.6.13-rc6-aes.orig/drivers/w1/w1.c
+++ linux-2.6.13-rc6-aes/drivers/w1/w1.c
@@ -593,7 +593,8 @@ void w1_search(struct w1_master *dev, w1
* Return 0 - device(s) present, 1 - no devices present.
*/
if (w1_reset_bus(dev)) {
- dev_info(&dev->dev, "No devices present on the wire.\n");
+ if (printk_ratelimit())
+ dev_debug(&dev->dev, "No devices present on the wire.\n");
break;
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kernel spams syslog every 10 sec with w1 debug
2005-08-12 15:07 [PATCH] kernel spams syslog every 10 sec with w1 debug Olaf Hering
@ 2005-08-12 15:37 ` Evgeniy Polyakov
0 siblings, 0 replies; 6+ messages in thread
From: Evgeniy Polyakov @ 2005-08-12 15:37 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-kernel, Andrew Morton
On Fri, Aug 12, 2005 at 05:07:48PM +0200, Olaf Hering (olh@suse.de) wrote:
>
> Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.
>
> After installing 10.0 B1, I found this in my syslog:
> Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
> Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
>
> Signed-off-by: Olaf Hering <olh@suse.de>
>
> drivers/w1/w1.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.13-rc6-aes/drivers/w1/w1.c
> ===================================================================
> --- linux-2.6.13-rc6-aes.orig/drivers/w1/w1.c
> +++ linux-2.6.13-rc6-aes/drivers/w1/w1.c
> @@ -593,7 +593,8 @@ void w1_search(struct w1_master *dev, w1
> * Return 0 - device(s) present, 1 - no devices present.
> */
> if (w1_reset_bus(dev)) {
> - dev_info(&dev->dev, "No devices present on the wire.\n");
> + if (printk_ratelimit())
> + dev_debug(&dev->dev, "No devices present on the wire.\n");
> break;
> }
I would even just replace it with dev_dbg(),
since default 10 seconds timeout is more than printk_ratelimit_jiffies.
I will add such a patch into w1 queue.
Thank you.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20050812150748.GA6774@suse.de.suse.lists.linux.kernel>]
* Re: [PATCH] kernel spams syslog every 10 sec with w1 debug
[not found] <20050812150748.GA6774@suse.de.suse.lists.linux.kernel>
@ 2005-08-12 15:38 ` Andi Kleen
2005-08-12 15:40 ` Olaf Hering
2005-08-12 16:00 ` Dave Jones
0 siblings, 2 replies; 6+ messages in thread
From: Andi Kleen @ 2005-08-12 15:38 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-kernel
Olaf Hering <olh@suse.de> writes:
> Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.
>
> After installing 10.0 B1, I found this in my syslog:
> Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
> Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
More interesting is why this thing is running at all.
It shouldn't.
-Andi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kernel spams syslog every 10 sec with w1 debug
2005-08-12 15:38 ` Andi Kleen
@ 2005-08-12 15:40 ` Olaf Hering
2005-08-12 16:00 ` Dave Jones
1 sibling, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2005-08-12 15:40 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel
On Fri, Aug 12, Andi Kleen wrote:
> Olaf Hering <olh@suse.de> writes:
>
> > Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.
> >
> > After installing 10.0 B1, I found this in my syslog:
> > Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
> > Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
>
> More interesting is why this thing is running at all.
> It shouldn't.
Maybe these cables can be plugged in at any time and the driver is
polling. Havent looked how things work.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel spams syslog every 10 sec with w1 debug
2005-08-12 15:38 ` Andi Kleen
2005-08-12 15:40 ` Olaf Hering
@ 2005-08-12 16:00 ` Dave Jones
2005-08-24 21:28 ` Hans-Peter Jansen
1 sibling, 1 reply; 6+ messages in thread
From: Dave Jones @ 2005-08-12 16:00 UTC (permalink / raw)
To: Andi Kleen; +Cc: Olaf Hering, linux-kernel
On Fri, Aug 12, 2005 at 05:38:37PM +0200, Andi Kleen wrote:
> Olaf Hering <olh@suse.de> writes:
>
> > Bug 104020 - kernel spams syslog every 10 sec with: w1_driver w1_bus_master1: No devices present on the wire.
> >
> > After installing 10.0 B1, I found this in my syslog:
> > Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
> > Aug 10 23:40:16 linux kernel: w1_driver w1_bus_master1: No devices present on the wire.
>
> More interesting is why this thing is running at all.
> It shouldn't.
Doesnt that get loaded if there's a Matrox card present ?
(I am completely guessing here, so could be way off base).
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel spams syslog every 10 sec with w1 debug
2005-08-12 16:00 ` Dave Jones
@ 2005-08-24 21:28 ` Hans-Peter Jansen
0 siblings, 0 replies; 6+ messages in thread
From: Hans-Peter Jansen @ 2005-08-24 21:28 UTC (permalink / raw)
To: Dave Jones; +Cc: Andi Kleen, Olaf Hering, linux-kernel
Am Freitag, 12. August 2005 18:00 schrieb Dave Jones:
> On Fri, Aug 12, 2005 at 05:38:37PM +0200, Andi Kleen wrote:
> > Olaf Hering <olh@suse.de> writes:
> > > Bug 104020 - kernel spams syslog every 10 sec with: w1_driver
> > > w1_bus_master1: No devices present on the wire.
> > >
> > > After installing 10.0 B1, I found this in my syslog:
> > > Aug 10 23:40:06 linux kernel: w1_driver w1_bus_master1: No
> > > devices present on the wire. Aug 10 23:40:16 linux kernel:
> > > w1_driver w1_bus_master1: No devices present on the wire.
> >
> > More interesting is why this thing is running at all.
> > It shouldn't.
>
> Doesnt that get loaded if there's a Matrox card present ?
> (I am completely guessing here, so could be way off base).
Guess matched! Most of my systems run these (should I say unfortunately
8|)
And sorry for the late reply. I didn't notice, that my report leaked
into lkml.. ;-)
Pete
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-08-24 21:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-12 15:07 [PATCH] kernel spams syslog every 10 sec with w1 debug Olaf Hering
2005-08-12 15:37 ` Evgeniy Polyakov
[not found] <20050812150748.GA6774@suse.de.suse.lists.linux.kernel>
2005-08-12 15:38 ` Andi Kleen
2005-08-12 15:40 ` Olaf Hering
2005-08-12 16:00 ` Dave Jones
2005-08-24 21:28 ` Hans-Peter Jansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox