From: Matt Mackall <mpm@selenic.com>
To: John Ronciak <john.ronciak@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
ak@suse.de, Jeff Moyer <jmoyer@redhat.com>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
john.ronciak@intel.com, rostedt@goodmis.org
Subject: Re: [PATCH 3/8] netpoll: e1000 netpoll tweak
Date: Fri, 12 Aug 2005 12:17:52 -0700 [thread overview]
Message-ID: <20050812191752.GI12284@waste.org> (raw)
In-Reply-To: <56a8daef0508121202172bcd17@mail.gmail.com>
[corrected akpm's address]
On Fri, Aug 12, 2005 at 12:02:03PM -0700, John Ronciak wrote:
> Sorry this reply was to go to the whole list but only made it to Matt.
>
> The e1000_intr() routine already calls e1000_clean_tx_irq(). So
> what's the point of this patch? Am I missing something?
Here is Steven's original analysis:
http://lkml.org/lkml/2005/8/5/116
It looked plausible, but I didn't dig much deeper.
> > Index: l/drivers/net/e1000/e1000_main.c
> > ===================================================================
> > --- l.orig/drivers/net/e1000/e1000_main.c 2005-08-06 17:36:32.000000000 -0500
> > +++ l/drivers/net/e1000/e1000_main.c 2005-08-06 17:55:01.000000000 -0500
> > @@ -3789,6 +3789,7 @@ e1000_netpoll(struct net_device *netdev)
> > struct e1000_adapter *adapter = netdev_priv(netdev);
> > disable_irq(adapter->pdev->irq);
> > e1000_intr(adapter->pdev->irq, netdev, NULL);
> > + e1000_clean_tx_irq(adapter);
> > enable_irq(adapter->pdev->irq);
> > }
> > #endif
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-08-12 19:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 2:18 [PATCH 0/8] netpoll: various bugfixes Matt Mackall
2005-08-12 2:19 ` [PATCH 1/8] netpoll: rx_flags bugfix Matt Mackall
2005-08-12 2:19 ` [PATCH 2/8] netpoll: deadlock bugfix Matt Mackall
2005-08-12 2:19 ` [PATCH 3/8] netpoll: e1000 netpoll tweak Matt Mackall
2005-08-12 2:19 ` [PATCH 4/8] netpoll: netpoll_send_skb simplify Matt Mackall
2005-08-12 2:19 ` [PATCH 5/8] netpoll: add retry timeout Matt Mackall
2005-08-12 2:19 ` [PATCH 6/8] netpoll: pre-fill skb pool Matt Mackall
2005-08-12 2:19 ` [PATCH 7/8] netpoll: fix initialization/NAPI race Matt Mackall
2005-08-12 2:19 ` [PATCH 8/8] netpoll: remove unused variable Matt Mackall
2005-08-12 19:02 ` [PATCH 3/8] netpoll: e1000 netpoll tweak John Ronciak
2005-08-12 19:10 ` David S. Miller
2005-08-12 19:17 ` Matt Mackall [this message]
2005-08-12 2:41 ` [PATCH 0/8] netpoll: various bugfixes David S. Miller
2005-08-12 17:21 ` Olaf Hering
2005-08-12 19:21 ` Matt Mackall
2005-08-12 19:31 ` Olaf Hering
2005-08-14 21:00 ` Matt Mackall
2005-08-15 6:16 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050812191752.GI12284@waste.org \
--to=mpm@selenic.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jmoyer@redhat.com \
--cc=john.ronciak@gmail.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@oss.sgi.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox