From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Kumar Gala <galak@freescale.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linuppc-embedded@freescale.com,
vbordug@ru.mvista.com
Subject: Re: [PATCH] cpm_uart: Fix spinlock initialization
Date: Fri, 12 Aug 2005 20:46:17 +0100 [thread overview]
Message-ID: <20050812204617.C21152@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0508121132060.18385@nylon.am.freescale.net>; from galak@freescale.com on Fri, Aug 12, 2005 at 11:32:57AM -0500
On Fri, Aug 12, 2005 at 11:32:57AM -0500, Kumar Gala wrote:
> The lack of spin_lock_init causes badness in the preempt configuration.
Please don't - I have a patch in the wings which fixes this properly.
Unfortunately, its behind a ton of other patches, and I don't want
to try to find all these fixes in each driver.
This is wrong because we will re-initialise it from an indeterminant
state (it might be locked) later during the initialisation. Let's
fix it properly.
(Since Linus pulled the shutters down when I still had a large chunk
of stuff in my serial tree, my serial patch merging is currently at
a complete standstill.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-08-12 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 16:32 [PATCH] cpm_uart: Fix spinlock initialization Kumar Gala
2005-08-12 19:46 ` Russell King [this message]
2005-08-12 19:54 ` Kumar Gala
2005-08-12 22:03 ` Alan Cox
2005-08-12 21:58 ` David S. Miller
2005-08-13 11:41 ` Alan Cox
2005-08-13 19:15 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050812204617.C21152@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=galak@freescale.com \
--cc=linuppc-embedded@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox