From: Con Kolivas <kernel@kolivas.org>
To: vatsa@in.ibm.com
Cc: ck@vds.kolivas.org, tony@atomide.com,
tuukka.tikkanen@elektrobit.com, akpm@osdl.org,
johnstul@us.ibm.com, linux-kernel@vger.kernel.org, ak@muc.de,
schwidefsky@de.ibm.com, george@mvista.com
Subject: Re: [ck] [PATCH] dynamic-tick patch modified for SMP
Date: Sun, 14 Aug 2005 00:53:20 +1000 [thread overview]
Message-ID: <200508140053.21056.kernel@kolivas.org> (raw)
In-Reply-To: <20050813113717.GB4550@in.ibm.com>
On Sat, 13 Aug 2005 21:37, Srivatsa Vaddagiri wrote:
> On Sat, Aug 13, 2005 at 04:51:07PM +1000, Con Kolivas wrote:
> > I'm sorry to say this doesn't appear to skip any ticks on my single P4
> > with SMP/SMT enabled.
>
> Con,
> I had enabled skipping ticks only in default_idle routine. So if
> you have a different idle route (which I suspect is the case), it will not
> skip ticks (since dyn_tick_reprogram_timer will not be called).
> Can you try this patch?
Indeed this fixes it on my P4 so that it does skip ticks. However presumably
due to the code change I am having the reverse behaviour from previously - it
pauses for ages when using PIT - worse so than previously in that if I dont
generate interrupts with my mouse or keyboard it just sits there
indefinitely. Having said that, it seems to work fine in APIC mode.
Without any modifications yet (I won't touch the code while you're busy with
it), here is a rolled up patch of yours on top of mine for those wanting to
try all the code:
http://ck.kolivas.org/patches/dyn-ticks/2.6.13-rc6-dtck-2.patch
Cheers,
Con
next prev parent reply other threads:[~2005-08-13 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 20:19 [PATCH] dynamic-tick patch modified for SMP Srivatsa Vaddagiri
2005-08-13 1:35 ` [ck] " Con Kolivas
2005-08-13 6:51 ` Con Kolivas
2005-08-13 11:37 ` Srivatsa Vaddagiri
2005-08-13 14:53 ` Con Kolivas [this message]
2005-08-13 16:46 ` Srivatsa Vaddagiri
2005-08-14 0:18 ` Con Kolivas
2005-08-14 4:15 ` Kyle Moffett
2005-08-15 15:47 ` Srivatsa Vaddagiri
2005-08-15 16:39 ` john stultz
2005-08-16 2:11 ` Srivatsa Vaddagiri
2005-08-15 15:35 ` Srivatsa Vaddagiri
2005-08-15 16:30 ` Con Kolivas
2005-08-16 13:19 ` Srivatsa Vaddagiri
2005-08-16 13:23 ` Con Kolivas
2005-08-17 7:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508140053.21056.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=george@mvista.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tony@atomide.com \
--cc=tuukka.tikkanen@elektrobit.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox