Re: [xfs-masters] [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage

Christoph Hellwig
2005-08-15T20:36:59Z

On Mon, Aug 15, 2005 at 11:40:13AM -0700, Nishanth Aravamudan wrote:
> Hrm, I got dropped from the Cc list...? No worries, I'm subscribed in
> two places :)

I didn't do that manually, must haven some mail header thing.

> I think your reference to "last time" is the KJ patches which probably
> used msleep{,_interruptible}() instead of schedule_timeout(). This
> patchset, in contrast, should result in *no* functional changes (beyond
> some more precisie conversions, where appropriate).
> schedule_timeout_interruptible(some_value), for instance is nothing more than:
>
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_value);
>
> Just in the form of a combine function call. No loops like msleep() &
> co.
>
> Is the patch still a problem?

No, it's fine. Sorry for the noise.