Re: [xfs-masters] [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage

Nishanth Aravamudan
2005-08-15T18:40:23Z

On 15.08.2005 [20:17:52 +0200], Christoph Hellwig wrote:
> On Mon, Aug 15, 2005 at 11:08:04AM -0700, Nishanth Aravamudan wrote:
> > Description: Use schedule_timeout_{,un}interruptible() instead of
> > set_current_state()/schedule_timeout() to reduce kernel size. Also use
> > helper functions to convert between human time units and jiffies rather
> > than constant HZ division to avoid rounding errors.
>
> The XFS changes are still wrong for the same rason as last time,
> we actually do want the daemons to do work if they're woken earlier
> using wake_up_process.

Hrm, I got dropped from the Cc list...? No worries, I'm subscribed in
two places :)

I think your reference to "last time" is the KJ patches which probably
used msleep{,_interruptible}() instead of schedule_timeout(). This
patchset, in contrast, should result in *no* functional changes (beyond
some more precisie conversions, where appropriate).
schedule_timeout_interruptible(some_value), for instance is nothing more than:

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_value);

Just in the form of a combine function call. No loops like msleep() &
co.

Is the patch still a problem?

Thanks,
Nish