From: Jeff Dike <jdike@addtoit.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Fix mmap_kmem (was: [question] What's the difference between /dev/kmem and /dev/mem)
Date: Mon, 15 Aug 2005 17:14:19 -0400 [thread overview]
Message-ID: <20050815211419.GA7348@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20050815193307.GA11025@aepfle.de>
On Mon, Aug 15, 2005 at 09:33:07PM +0200, Olaf Hering wrote:
> ARCH=um doesnt like your version, but mine.
>
> drivers/char/mem.c:267: error: invalid operands to binary <<
>
> pfn = (__pa((u64)vma->vm_pgoff) << PAGE_SHIFT) >> PAGE_SHIFT;
My page.h was missing some parens. Try the patch below.
Jeff
Index: linux-2.6.13-rc6/include/asm-um/page.h
===================================================================
--- linux-2.6.13-rc6.orig/include/asm-um/page.h 2005-08-15 16:57:55.000000000 -0400
+++ linux-2.6.13-rc6/include/asm-um/page.h 2005-08-15 17:16:57.000000000 -0400
@@ -104,8 +104,8 @@
* casting is the right thing, but 32-bit UML can't have 64-bit virtual
* addresses
*/
-#define __pa(virt) to_phys((void *) (unsigned long) virt)
-#define __va(phys) to_virt((unsigned long) phys)
+#define __pa(virt) to_phys((void *) (unsigned long) (virt))
+#define __va(phys) to_virt((unsigned long) (phys))
#define page_to_pfn(page) ((page) - mem_map)
#define pfn_to_page(pfn) (mem_map + (pfn))
next prev parent reply other threads:[~2005-08-15 21:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 21:36 [question] What's the difference between /dev/kmem and /dev/mem Steven Rostedt
2005-08-12 1:15 ` [PATCH] Fix mmap_kmem (was: [question] What's the difference between /dev/kmem and /dev/mem) Steven Rostedt
2005-08-12 14:25 ` Hugh Dickins
2005-08-12 16:35 ` Linus Torvalds
2005-08-12 16:56 ` Dave Jones
2005-08-12 17:07 ` Steven Rostedt
2005-08-12 17:16 ` Arjan van de Ven
2005-08-12 17:32 ` Steven Rostedt
2005-08-12 17:01 ` Steven Rostedt
2005-08-13 13:39 ` [PATCH] Fix mmap kmem " Nicolas George
2005-08-13 16:50 ` [PATCH] Fix mmap_kmem " Arjan van de Ven
2005-08-13 16:56 ` Linus Torvalds
2005-08-13 17:25 ` Arjan van de Ven
2005-08-13 17:37 ` Linus Torvalds
2005-08-13 18:18 ` Arjan van de Ven
2005-08-16 22:12 ` Greg Edwards
2005-08-16 23:33 ` Alan Cox
2005-08-16 23:47 ` Steven Rostedt
2005-08-15 19:33 ` Olaf Hering
2005-08-15 21:14 ` Jeff Dike [this message]
2005-08-15 21:50 ` Olaf Hering
2005-08-15 22:41 ` Linus Torvalds
2005-08-16 1:16 ` Steven Rostedt
2005-08-16 1:22 ` Steven Rostedt
2005-08-16 1:36 ` Linus Torvalds
2005-08-13 16:57 ` Joshua Hudson
2005-08-13 17:27 ` Arjan van de Ven
2005-08-14 14:50 ` Martin J. Bligh
2005-08-18 14:07 ` Arjan van de Ven
2005-08-18 14:18 ` Steven Rostedt
[not found] <1123796188.17269.127.camel@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <1123809302.17269.139.camel@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.58.0508120930150.3295@g5.osdl.org.suse.lists.linux.kernel>
2005-08-12 16:54 ` Andi Kleen
2005-08-12 17:56 ` Arjan van de Ven
2005-08-12 18:26 ` Andi Kleen
2005-08-13 9:56 ` Ingo Oeser
2005-08-13 12:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050815211419.GA7348@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox