Re: [RFC] RT-patch update to remove the global pi_lock

Ingo Molnar
2005-08-23T05:29:14Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

> > One downside would be an increase in mutex structure size though.
>
> If I do need to add an additional lock to the mutex, I would abstract
> it all, so that the old global pi_lock can be used if configured.
> This way, a UP or a low memory 2x SMP machine can still use the old
> method, but when it needs to grow, switch over to the new non-global
> pi_locking method. But, maybe I can still get away with just using
> the wait_lock and not add any more overhead to the size of the mutex.

We want to reduce configurability, not increase it. Having something
like a selectable _core design property_ leads to madness and hard to
maintain code very quickly.

also, we already have a per-lock spinlock. Why not use that?

Ingo