Re: [patch 3/7] PCI: fix quirk-6700-fix.patch

Andrew Morton
2005-08-17T00:28:34Z

Greg Kroah-Hartman <gregkh@suse.de> wrote:
>
> From: Andrew Morton <akpm@osdl.org>
>
> drivers/built-in.o(.text+0x32c3): In function `quirk_pcie_pxh':
> /usr/src/25/drivers/pci/quirks.c:1312: undefined reference to `disable_msi_mode'
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> drivers/pci/pci.h | 6 ++++++
> 1 files changed, 6 insertions(+)
>
> --- gregkh-2.6.orig/drivers/pci/pci.h 2005-08-16 14:57:46.000000000 -0700
> +++ gregkh-2.6/drivers/pci/pci.h 2005-08-16 14:57:47.000000000 -0700
> @@ -46,7 +46,13 @@ extern int pci_msi_quirk;
> #else
> #define pci_msi_quirk 0
> #endif
> +
> +#ifdef CONFIG_PCI_MSI
> void disable_msi_mode(struct pci_dev *dev, int pos, int type);
> +#else
> +static inline void disable_msi_mode(struct pci_dev *dev, int pos, int type) { }
> +#endif
> +
> extern int pcie_mch_quirk;
> extern struct device_attribute pci_dev_attrs[];
> extern struct class_device_attribute class_device_attr_cpuaffinity;
>

hm. I normally fold crappy little patches like this into the main patch
before sending it Linuswards. The submitter gets a mention in the s-o-b
record and perhaps a one-line description if the fix was less than utterly
trivial.

That's one advantage of the patch-scripts/quilt approach: these little
post-facto fixups don't pollute the upstream changelog record.