From: Tommy Reynolds <Tommy.Reynolds@MegaCoder.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, agl@us.ibm.com
Subject: Re: [RFC] Cleanup line-wrapping in pgtable.h
Date: Wed, 17 Aug 2005 13:00:35 -0500 [thread overview]
Message-ID: <20050817130035.4341592e.Tommy.Reynolds@MegaCoder.com> (raw)
In-Reply-To: <1124300739.3139.16.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
Uttered Adam Litke <agl@us.ibm.com>, spake thus:
> The line-wrapping in most of the include/asm/pgtable.h pte test/set
> macros looks horrible in my 80 column terminal. The following "test the
> waters" patch is how I would like to see them laid out. I realize that
> the braces don't adhere to CodingStyle but the advantage is (when taking
> wrapping into account) that the code takes up no additional space. How
> do people feel about making this change? Any better suggestions? I
> personally wouldn't like a lone closing brace like normal functions
> because of the extra lines eaten. I volunteer to patch up the other
> architectures if we reach a consensus.
Congratulations for keeping your 80-column display. The coding
standard assumes that and 8-character tabs for carefully thought-out
software development reasons -- they are functional, not traditional.
Since these are inline procedures, make them follow the coding
standard; that's why we have one.
Cheers
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-08-17 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-17 17:45 [RFC] Cleanup line-wrapping in pgtable.h Adam Litke
2005-08-17 17:56 ` Christoph Hellwig
2005-08-17 19:48 ` Alexey Dobriyan
2005-08-17 18:00 ` Tommy Reynolds [this message]
2005-08-17 18:19 ` Dave Hansen
2005-08-22 9:29 ` Pavel Machek
2005-08-22 21:11 ` Matthew Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050817130035.4341592e.Tommy.Reynolds@MegaCoder.com \
--to=tommy.reynolds@megacoder.com \
--cc=agl@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox