public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pull XFS support out of Kconfig submenu
@ 2005-08-17 20:44 Jesper Juhl
  0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2005-08-17 20:44 UTC (permalink / raw)
  To: xfs-masters; +Cc: nathans, linux-xfs, linux-kernel

It seems slightly odd to me that XFS support should be in a seperate submenu,
when all the other filesystems are not using submenus but are directly 
selectable from the Filesystems menu.
This patch makes XFS Kconfig entries behave like everything else.

Ignore if there's a good reason for the menu, please consider applying 
otherwise.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 fs/xfs/Kconfig |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

--- linux-2.6.13-rc6-git9-orig/fs/xfs/Kconfig	2005-06-17 21:48:29.000000000 +0200
+++ linux-2.6.13-rc6-git9/fs/xfs/Kconfig	2005-08-17 22:38:26.000000000 +0200
@@ -1,5 +1,3 @@
-menu "XFS support"
-
 config XFS_FS
 	tristate "XFS filesystem support"
 	select EXPORTFS if NFSD!=n
@@ -22,6 +20,7 @@
 
 config XFS_EXPORT
 	bool
+	depends on XFS_FS
 	default y if XFS_FS && EXPORTFS
 
 config XFS_RT
@@ -81,5 +80,3 @@
 	  Linux website <http://acl.bestbits.at/>.
 
 	  If you don't know what Access Control Lists are, say N.
-
-endmenu



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] pull XFS support out of Kconfig submenu
@ 2005-08-17 20:45 Jesper Juhl
  2005-08-18 13:53 ` Chris Wedgwood
  0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2005-08-17 20:45 UTC (permalink / raw)
  To: xfs-masters; +Cc: nathans, linux-xfs, linux-kernel

It seems slightly odd to me that XFS support should be in a separate submenu,
when all the other filesystems are not using submenus but are directly 
selectable from the Filesystems menu.
This patch makes XFS Kconfig entries behave like everything else.

Ignore if there's a good reason for the menu, please consider applying 
otherwise.

Please Cc: me on replies.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 fs/xfs/Kconfig |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

--- linux-2.6.13-rc6-git9-orig/fs/xfs/Kconfig	2005-06-17 21:48:29.000000000 +0200
+++ linux-2.6.13-rc6-git9/fs/xfs/Kconfig	2005-08-17 22:38:26.000000000 +0200
@@ -1,5 +1,3 @@
-menu "XFS support"
-
 config XFS_FS
 	tristate "XFS filesystem support"
 	select EXPORTFS if NFSD!=n
@@ -22,6 +20,7 @@
 
 config XFS_EXPORT
 	bool
+	depends on XFS_FS
 	default y if XFS_FS && EXPORTFS
 
 config XFS_RT
@@ -81,5 +80,3 @@
 	  Linux website <http://acl.bestbits.at/>.
 
 	  If you don't know what Access Control Lists are, say N.
-
-endmenu



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pull XFS support out of Kconfig submenu
  2005-08-17 20:45 Jesper Juhl
@ 2005-08-18 13:53 ` Chris Wedgwood
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Wedgwood @ 2005-08-18 13:53 UTC (permalink / raw)
  To: Jesper Juhl; +Cc: xfs-masters, nathans, linux-xfs, linux-kernel

On Wed, Aug 17, 2005 at 10:45:48PM +0200, Jesper Juhl wrote:

> It seems slightly odd to me that XFS support should be in a separate
> submenu, when all the other filesystems are not using submenus but
> are directly selectable from the Filesystems menu.

XFS also has an out-of-tree version.  Making it a submenu is probably
to make maintenance easier (ie. replace files, not merge).


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-08-18 13:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-17 20:44 [PATCH] pull XFS support out of Kconfig submenu Jesper Juhl
  -- strict thread matches above, loose matches on Subject: below --
2005-08-17 20:45 Jesper Juhl
2005-08-18 13:53 ` Chris Wedgwood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox