public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: Multi-sector writes
Date: Thu, 18 Aug 2005 09:23:21 +0100	[thread overview]
Message-ID: <20050818092321.B3966@flint.arm.linux.org.uk> (raw)
In-Reply-To: <4304380B.5070406@drzeus.cx>; from drzeus-list@drzeus.cx on Thu, Aug 18, 2005 at 09:26:03AM +0200

On Thu, Aug 18, 2005 at 09:26:03AM +0200, Pierre Ossman wrote:
> We had this discussion on LKML and Alan Cox' comment on it was that a
> solution like this would be acceptable, where we try and shove
> everything out first and then fall back on sector-by-sector to determine
> where an error occurs. This will only break if the problematic sector
> keeps shifting around, but at that point the card is probably toast
> anyway (if the thing keeps moving how can you bad block it?).

There are two different kinds of error - the ones at the transport
level which we are able to force a result of "no sectors transferred"
for.  For all other errors and successful completions, the driver
reports "all sectors tranferred" since the driver level doesn't know
that an error occurred.

This causes us to tell the upper levels that we were successful,
even if we weren't.  Hence the problem.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2005-08-18  8:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-14 12:41 [PATCH] mmc: Multi-sector writes Pierre Ossman
2005-08-17 22:56 ` Andrew Morton
2005-08-18  5:48   ` Pierre Ossman
2005-08-18  5:48     ` Andrew Morton
2005-08-18  6:38       ` Russell King
2005-08-18  7:26         ` Pierre Ossman
2005-08-18  8:23           ` Russell King [this message]
2005-08-18  8:48             ` Pierre Ossman
2005-08-18 20:19               ` Pavel Machek
2005-08-19  5:00                 ` Pierre Ossman
2005-08-19  7:58                   ` Pavel Machek
2005-08-19  8:12                     ` Pierre Ossman
2005-08-18  9:42           ` Alan Cox
2005-08-18  9:33             ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050818092321.B3966@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox