Re: xtensa-clean-up-system-call-list-and-interface.patch added to -mm tree

[Arnd Bergmann <arnd@arndb.de>]

On Middeweken 17 August 2005 21:52, akpm@osdl.org wrote:
> +#ifdef __KERNEL_SYSCALLS__
>  
> +#include <linux/compiler.h>
> +#include <linux/types.h>
> +#include <linux/syscalls.h>
> +
> +struct pt_regs;
> +struct sigaction;
> +asmlinkage long xtensa_execve(char *filenamei, char **argv, char **envp,
> +                             struct pt_regs *regs);
> +asmlinkage long xtensa_clone(unsigned long clone_flags, unsigned long newsp,
> +                            struct pt_regs *regs);
> +asmlinkage long xtensa_pipe(unsigned long *fildes);
> +asmlinkage long xtensa_ptrace(long request, long pid, long addr, long data);
> +asmlinkage long xtensa_rt_sigaction(int sig,
> +                                   const struct sigaction __user *act,
> +                                   struct sigaction __user *oact,
> +                                   size_t sigsetsize);
>  

These definitions should not be #ifdef __KERNEL_SYSCALLS__. That define
used to have a very different meaning, which is now deprecated.

I think it would be best to simply put all the above stuff into a new
asm/syscalls.h which is then included from arch/xtensa/kernel/syscalls.c.

	Arnd <><