From: Greg KH <greg@kroah.com>
To: Daniel Phillips <phillips@istop.com>
Cc: Joel Becker <Joel.Becker@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Permissions don't stick on ConfigFS attributes
Date: Fri, 19 Aug 2005 20:33:37 -0700 [thread overview]
Message-ID: <20050820033337.GA1173@kroah.com> (raw)
In-Reply-To: <200508201323.29355.phillips@istop.com>
On Sat, Aug 20, 2005 at 01:23:29PM +1000, Daniel Phillips wrote:
> On Saturday 20 August 2005 13:01, Greg KH wrote:
> > On Sat, Aug 20, 2005 at 10:50:51AM +1000, Daniel Phillips wrote:
> > > So: Integrate with sysfs.
> >
> > No, don't. Do you think that Joel would not have already worked with
> > the sysfs people prior to submitting this? No, he did, and we all
> > agreed that it should be kept separate.
>
> Would you care to recap the reasoning, please?
They do two different things, and people interact with them in two
different ways. So, they should be two different file systems.
> > > Terminology skew. It is a very bad idea to call your configfs files
> > > "attributes".
> >
> > That's what sysfs calls its files. They used the same naming scheme
> > there. This is nothing that a user ever cares about or sees.
>
> It's wrrrrronnnggg. The best you can defend this with is "it's entrenched".
Will a user ever see the word "attribute"? Also, these files represent
attributes of the main object in which they are attached to. Hence the
name.
> > > Memory requirements. ConfigFS pins way too much kernel memory for inodes
> > > and dentries.
> >
> > configfs is not going to have that many nodes at all in memory (compared
> > to sysfs), so I don't think this is a big problem.
>
> The current bloat is unconscionable, for the amount of data that is carried.
> Are you arguing against fixing it? And what makes you think configfs will
> never have lots of nodes?
Doesn't it currently work the same way as sysfs with the backing store
being created on the fly? If not, it should be pretty simple to convert
over if people are really worried about memory consumption, but again,
why don't we see how many nodes are really used on most systems (don't
want to add more complexity and kernel code if you never really need
it.)
thanks,
greg k-h
next prev parent reply other threads:[~2005-08-20 3:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 0:50 [PATCH] Permissions don't stick on ConfigFS attributes Daniel Phillips
2005-08-20 1:22 ` Jon Smirl
2005-08-20 6:21 ` Daniel Phillips
2005-08-20 3:01 ` Greg KH
2005-08-20 3:23 ` Daniel Phillips
2005-08-20 3:33 ` Greg KH [this message]
2005-08-20 5:41 ` Daniel Phillips
2005-08-20 6:31 ` Joel Becker
2005-08-20 7:35 ` Daniel Phillips
2005-08-20 21:09 ` [PATCH] Permissions don't stick on ConfigFS attributes (revised) Daniel Phillips
2005-08-22 4:49 ` [PATCH] Permissions don't stick on ConfigFS attributes Eric W. Biederman
2005-08-22 19:44 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050820033337.GA1173@kroah.com \
--to=greg@kroah.com \
--cc=Joel.Becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@istop.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox