From: Adrian Bunk <bunk@stusta.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] adapt scripts/ver_linux to new util-linux version strings
Date: Sat, 20 Aug 2005 21:02:42 +0200 [thread overview]
Message-ID: <20050820190242.GY3615@stusta.de> (raw)
In-Reply-To: <20050820055532.GA15577@mipter.zuzino.mipt.ru>
On Sat, Aug 20, 2005 at 09:55:32AM +0400, Alexey Dobriyan wrote:
> On Sat, Aug 20, 2005 at 05:58:53AM +0200, Adrian Bunk wrote:
> > --- linux-2.6.13-rc6-mm1-full/scripts/ver_linux.old
> > +++ linux-2.6.13-rc6-mm1-full/scripts/ver_linux
>
> > -fdformat --version | awk -F\- '{print "util-linux ", $NF}'
> > +fdformat --version | awk '{print "util-linux ", $NF}' \
> > +| awk -F\) '{print $1}'
> >
> > -mount --version | awk -F\- '{print "mount ", $NF}'
> > +mount --version | awk '{print "mount ", $NF}' | \
> > +awk -F\) '{print $1}'
>
> -util-linux 2.12i
> -mount 2.12i
> +util-linux util-linux-2.12i
> +mount mount-2.12i
> ^^^^^^
>
> Is this intentional?
After this patch, the new format is parsed correctly instead of
completely wrong.
You've found the small regression parsing the old format.
IMHO this is not a problem. If you disagree, feel free to send a better
patch.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-08-20 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 3:58 [2.6 patch] adapt scripts/ver_linux to new util-linux version strings Adrian Bunk
2005-08-20 5:55 ` Alexey Dobriyan
2005-08-20 19:02 ` Adrian Bunk [this message]
2005-08-21 9:26 ` [PATCH] Adapt " Alexey Dobriyan
2005-08-21 15:29 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050820190242.GY3615@stusta.de \
--to=bunk@stusta.de \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox