* [2.6 patch] include/linux/quotaops.h: "extern inline" doesn't make sense
@ 2005-08-20 19:25 Adrian Bunk
2005-08-22 9:50 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-08-20 19:25 UTC (permalink / raw)
To: jack; +Cc: linux-kernel
"extern inline" doesn't make sense.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/linux/quotaops.h | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
--- linux-2.6.13-rc6-mm1/include/linux/quotaops.h.old 2005-08-20 14:40:53.000000000 +0200
+++ linux-2.6.13-rc6-mm1/include/linux/quotaops.h 2005-08-20 14:41:30.000000000 +0200
@@ -198,38 +198,38 @@
#define DQUOT_SYNC(sb) do { } while(0)
#define DQUOT_OFF(sb) do { } while(0)
#define DQUOT_TRANSFER(inode, iattr) (0)
-extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
+static inline int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
{
inode_add_bytes(inode, nr);
return 0;
}
-extern __inline__ int DQUOT_PREALLOC_SPACE(struct inode *inode, qsize_t nr)
+static inline int DQUOT_PREALLOC_SPACE(struct inode *inode, qsize_t nr)
{
DQUOT_PREALLOC_SPACE_NODIRTY(inode, nr);
mark_inode_dirty(inode);
return 0;
}
-extern __inline__ int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
+static inline int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
{
inode_add_bytes(inode, nr);
return 0;
}
-extern __inline__ int DQUOT_ALLOC_SPACE(struct inode *inode, qsize_t nr)
+static inline int DQUOT_ALLOC_SPACE(struct inode *inode, qsize_t nr)
{
DQUOT_ALLOC_SPACE_NODIRTY(inode, nr);
mark_inode_dirty(inode);
return 0;
}
-extern __inline__ void DQUOT_FREE_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
+static inline void DQUOT_FREE_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
{
inode_sub_bytes(inode, nr);
}
-extern __inline__ void DQUOT_FREE_SPACE(struct inode *inode, qsize_t nr)
+static inline void DQUOT_FREE_SPACE(struct inode *inode, qsize_t nr)
{
DQUOT_FREE_SPACE_NODIRTY(inode, nr);
mark_inode_dirty(inode);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] include/linux/quotaops.h: "extern inline" doesn't make sense
2005-08-20 19:25 [2.6 patch] include/linux/quotaops.h: "extern inline" doesn't make sense Adrian Bunk
@ 2005-08-22 9:50 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2005-08-22 9:50 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, akpm
> "extern inline" doesn't make sense.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Looks good.
Signed-off-by: Jan Kara <jack@suse.cz>
Honza
> ---
>
> include/linux/quotaops.h | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.13-rc6-mm1/include/linux/quotaops.h.old 2005-08-20 14:40:53.000000000 +0200
> +++ linux-2.6.13-rc6-mm1/include/linux/quotaops.h 2005-08-20 14:41:30.000000000 +0200
> @@ -198,38 +198,38 @@
> #define DQUOT_SYNC(sb) do { } while(0)
> #define DQUOT_OFF(sb) do { } while(0)
> #define DQUOT_TRANSFER(inode, iattr) (0)
> -extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> inode_add_bytes(inode, nr);
> return 0;
> }
>
> -extern __inline__ int DQUOT_PREALLOC_SPACE(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_PREALLOC_SPACE(struct inode *inode, qsize_t nr)
> {
> DQUOT_PREALLOC_SPACE_NODIRTY(inode, nr);
> mark_inode_dirty(inode);
> return 0;
> }
>
> -extern __inline__ int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> inode_add_bytes(inode, nr);
> return 0;
> }
>
> -extern __inline__ int DQUOT_ALLOC_SPACE(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_ALLOC_SPACE(struct inode *inode, qsize_t nr)
> {
> DQUOT_ALLOC_SPACE_NODIRTY(inode, nr);
> mark_inode_dirty(inode);
> return 0;
> }
>
> -extern __inline__ void DQUOT_FREE_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> +static inline void DQUOT_FREE_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> inode_sub_bytes(inode, nr);
> }
>
> -extern __inline__ void DQUOT_FREE_SPACE(struct inode *inode, qsize_t nr)
> +static inline void DQUOT_FREE_SPACE(struct inode *inode, qsize_t nr)
> {
> DQUOT_FREE_SPACE_NODIRTY(inode, nr);
> mark_inode_dirty(inode);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-22 22:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-20 19:25 [2.6 patch] include/linux/quotaops.h: "extern inline" doesn't make sense Adrian Bunk
2005-08-22 9:50 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox