From: Denis Vlasenko <vda@ilport.com.ua>
To: Chris Wright <chrisw@osdl.org>,
linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
"Randy.Dunlap" <rdunlap@xenotime.net>,
Chuck Wolber <chuckw@quantumlinux.com>,
torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
rusty@rustcorp.com.au, Daniel Drake <dsd@gentoo.org>,
Chris Wright <chrisw@osdl.org>
Subject: Re: [patch 8/8] [PATCH] Module per-cpu alignment cannot always be met
Date: Mon, 22 Aug 2005 09:58:17 +0300 [thread overview]
Message-ID: <200508220958.17800.vda@ilport.com.ua> (raw)
In-Reply-To: <20050811225649.386948000@localhost.localdomain>
On Friday 12 August 2005 01:54, Chris Wright wrote:
> -stable review patch. If anyone has any objections, please let us know.
> ------------------
>
> The module code assumes noone will ever ask for a per-cpu area more than
> SMP_CACHE_BYTES aligned. However, as these cases show, gcc asks sometimes
> asks for 32-byte alignment for the per-cpu section on a module, and if
> CONFIG_X86_L1_CACHE_SHIFT is 4, we hit that BUG_ON(). This is obviously an
> unusual combination, as there have been few reports, but better to warn
> than die.
gcc gets increasingly sadistic about alignment:
"char global_var[] = "larger than 32 bytes"; uses silly amounts of alignment even with -Os"
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22158
Please, everybody who thinks that _32_ _byte_ alignment
is outright silly, add your comments to this bugzilla entry.
--
vda
prev parent reply other threads:[~2005-08-22 22:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 22:54 [patch 0/8] -stable review Chris Wright
2005-08-11 22:54 ` [patch 1/8] [PATCH] sys_set_mempolicy() doesnt check if mode < 0 Chris Wright
2005-08-11 22:54 ` [patch 2/8] [PATCH] Fix SRAT for non dual core AMD systems Chris Wright
2005-08-11 22:54 ` [patch 3/8] [PATCH] x86_64: Fixing smpboot timing problem Chris Wright
2005-08-11 23:33 ` Andi Kleen
2005-08-11 23:43 ` Chris Wright
2005-08-12 2:32 ` Eric W. Biederman
2005-08-12 4:26 ` [PATCH] x86_64: Fix apicid versus cpu# confusion Eric W. Biederman
2005-08-12 5:51 ` yhlu
2005-08-11 22:54 ` [patch 4/8] [PATCH] Update in-kernel zlib routines Chris Wright
2005-08-12 0:01 ` Peter Osterlund
2005-08-12 0:11 ` Chris Wright
2005-08-11 22:54 ` [patch 5/8] Check input buffer size in zisofs Chris Wright
2005-08-12 1:12 ` H. Peter Anvin
2005-08-12 1:16 ` Chris Wright
2005-08-11 22:54 ` [patch 6/8] CAN-2005-2098 Error during attempt to join key management session can leave semaphore pinned Chris Wright
2005-08-11 22:54 ` [patch 7/8] CAN-2005-2099 Destruction of failed keyring oopses Chris Wright
2005-08-11 22:54 ` [patch 8/8] [PATCH] Module per-cpu alignment cannot always be met Chris Wright
2005-08-22 6:58 ` Denis Vlasenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508220958.17800.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chrisw@osdl.org \
--cc=chuckw@quantumlinux.com \
--cc=dsd@gentoo.org \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rusty@rustcorp.com.au \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox