* [2.6 patch] SECURITY must depend on SYSFS
@ 2005-08-22 16:20 Adrian Bunk
2005-08-22 17:30 ` Chris Wright
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-08-22 16:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: chrisw, linux-security-module, linux-kernel
CONFIG_SECURITY=y and CONFIG_SYSFS=n results in the following compile
error:
<-- snip -->
...
LD vmlinux
security/built-in.o: In function `securityfs_init':
inode.c:(.init.text+0x1c2): undefined reference to `kernel_subsys'
make: *** [vmlinux] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 24 Jul 2005
--- linux-2.6.13-rc3-mm1-full/security/Kconfig.old 2005-07-23 20:21:09.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/security/Kconfig 2005-07-23 20:22:22.000000000 +0200
@@ -35,6 +35,7 @@
config SECURITY
bool "Enable different security models"
+ depends on SYSFS
help
This allows you to choose different security modules to be
configured into your kernel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] SECURITY must depend on SYSFS
2005-08-22 16:20 [2.6 patch] SECURITY must depend on SYSFS Adrian Bunk
@ 2005-08-22 17:30 ` Chris Wright
2005-08-22 20:38 ` Adrian Bunk
2005-08-22 20:47 ` Roman Zippel
0 siblings, 2 replies; 6+ messages in thread
From: Chris Wright @ 2005-08-22 17:30 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, chrisw, linux-security-module, linux-kernel
* Adrian Bunk (bunk@stusta.de) wrote:
> config SECURITY
> bool "Enable different security models"
> + depends on SYSFS
Hmm, what about select instead?
thanks,
-chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] SECURITY must depend on SYSFS
2005-08-22 17:30 ` Chris Wright
@ 2005-08-22 20:38 ` Adrian Bunk
2005-08-22 20:47 ` Roman Zippel
1 sibling, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-08-22 20:38 UTC (permalink / raw)
To: Chris Wright; +Cc: Andrew Morton, linux-security-module, linux-kernel
On Mon, Aug 22, 2005 at 10:30:03AM -0700, Chris Wright wrote:
> * Adrian Bunk (bunk@stusta.de) wrote:
> > config SECURITY
> > bool "Enable different security models"
> > + depends on SYSFS
>
> Hmm, what about select instead?
I have no strong opinion on this, especially since this is only an issue
in the COMFIG_EMBEDDED=y case.
> thanks,
> -chris
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] SECURITY must depend on SYSFS
2005-08-22 17:30 ` Chris Wright
2005-08-22 20:38 ` Adrian Bunk
@ 2005-08-22 20:47 ` Roman Zippel
2005-08-22 20:59 ` Chris Wright
1 sibling, 1 reply; 6+ messages in thread
From: Roman Zippel @ 2005-08-22 20:47 UTC (permalink / raw)
To: Chris Wright
Cc: Adrian Bunk, Andrew Morton, linux-security-module, linux-kernel
Hi,
On Mon, 22 Aug 2005, Chris Wright wrote:
> * Adrian Bunk (bunk@stusta.de) wrote:
> > config SECURITY
> > bool "Enable different security models"
> > + depends on SYSFS
>
> Hmm, what about select instead?
What's wrong with a normal dependency?
Please don't abuse select, use it only if you really have to.
bye, Roman
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] SECURITY must depend on SYSFS
2005-08-22 20:47 ` Roman Zippel
@ 2005-08-22 20:59 ` Chris Wright
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wright @ 2005-08-22 20:59 UTC (permalink / raw)
To: Roman Zippel
Cc: Chris Wright, Adrian Bunk, Andrew Morton, linux-security-module,
linux-kernel
* Roman Zippel (zippel@linux-m68k.org) wrote:
> What's wrong with a normal dependency?
Trying to enable when SYSFS under fs->pseudo->fs but security is under
security-> is just confusing, with no obvious (user perspective)
dependency.
> Please don't abuse select, use it only if you really have to.
OK, depends will be fine, esp. since it's just effecting CONFIG_EMBEDDED.
thanks,
-chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] SECURITY must depend on SYSFS
@ 2005-07-23 22:05 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-07-23 22:05 UTC (permalink / raw)
To: chrisw; +Cc: linux-security-module, linux-kernel
CONFIG_SECURITY=y and CONFIG_SYSFS=n results in the following compile
error:
<-- snip -->
...
LD vmlinux
security/built-in.o: In function `securityfs_init':
inode.c:(.init.text+0x1c2): undefined reference to `kernel_subsys'
make: *** [vmlinux] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc3-mm1-full/security/Kconfig.old 2005-07-23 20:21:09.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/security/Kconfig 2005-07-23 20:22:22.000000000 +0200
@@ -35,6 +35,7 @@
config SECURITY
bool "Enable different security models"
+ depends on SYSFS
help
This allows you to choose different security modules to be
configured into your kernel.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-08-22 21:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-22 16:20 [2.6 patch] SECURITY must depend on SYSFS Adrian Bunk
2005-08-22 17:30 ` Chris Wright
2005-08-22 20:38 ` Adrian Bunk
2005-08-22 20:47 ` Roman Zippel
2005-08-22 20:59 ` Chris Wright
-- strict thread matches above, loose matches on Subject: below --
2005-07-23 22:05 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox