From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org, mlindner@syskonnect.de
Subject: Re: skge missing ifdefs.
Date: Mon, 22 Aug 2005 16:33:54 -0400 [thread overview]
Message-ID: <20050822203354.GB3425@redhat.com> (raw)
In-Reply-To: <20050822132333.2ff893e6.akpm@osdl.org>
On Mon, Aug 22, 2005 at 01:23:33PM -0700, Andrew Morton wrote:
> Dave Jones <davej@redhat.com> wrote:
> >
> > On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote:
> > > On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote:
> > > > with CONFIG_PM undefined, the build breaks due to
> > > > undefined symbols.
> > >
> > > akpm already sent a fix to Linus.
> >
> > This is still broken afaics in todays -git.
> >
>
> Works for me. CONFIG_PM=n, CONFIG_SKGE=y or m, CONFIG_SK98LIN=y or m.
I missed the ..
#define skge_suspend NULL
#define skge_resume NULL
in drivers/net/sk98lin/skge.c, and wondered why my drivers/net/skge.c style fix
still applied.
Never mind, both drivers seem fine.
Dave
next prev parent reply other threads:[~2005-08-22 20:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 20:34 skge missing ifdefs Dave Jones
2005-08-01 20:38 ` Jeff Garzik
2005-08-22 19:59 ` Dave Jones
2005-08-22 20:22 ` David S. Miller
2005-08-22 20:23 ` Andrew Morton
2005-08-22 20:33 ` Dave Jones [this message]
2005-08-22 20:35 ` Al Viro
2005-08-22 20:42 ` Andrew Morton
2005-08-22 22:24 ` Roman Zippel
2005-08-23 6:02 ` Al Viro
2005-08-23 11:16 ` Roman Zippel
2005-08-23 21:44 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050822203354.GB3425@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox