Re: [PATCH 1/3] dlm: use configfs

[Mark Fasheh <mark.fasheh@oracle.com>]

On Fri, Aug 19, 2005 at 03:13:44PM +0800, David Teigland wrote:
> The nodemanager RFC I sent a month ago
>   http://marc.theaimsgroup.com/?l=linux-kernel&m=112166723919347&w=2
> 
> amounts to half of dlm/config.c (everything under comms/ above) moved into
> a separate kernel module.  That would be trivial to do, and is still an
> option to bat around.
Yeah ok, so the address/id/local part is still there. As is much of the API
to query those attributes.

> I question whether factoring such a small chunk into a separate module is
> really worth it, though?
IMHO, yes. Mostly because we both have very similar basic requirements there
and it seems a waste to have duplicated code (even if it's not a huge
amount). Future projects wanting to query basic node information from the
kernel could have simply used that API without having to further duplicate
code too. That said, I'm not sure it has to be done *now*

Was there anything in my comments which made going forward with that
approach difficult for dlm?

> Making all of config.c (all of /config/dlm/ above) into a separate module
> wouldn't seem quite so strange. It would require just a few lines of code
> to turn it into a stand alone module.
Without the dlm specifics, right? It's perfectly fine with me if dlm has a
couple more attributes that it wants on a node object - OCFS2 simply won't
query them.
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com