From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] fs/super.c: unexport user_get_super
Date: Tue, 23 Aug 2005 10:54:27 +0100 [thread overview]
Message-ID: <20050823095427.GA4425@infradead.org> (raw)
In-Reply-To: <20050822162056.GD9927@stusta.de>
On Mon, Aug 22, 2005 at 06:20:56PM +0200, Adrian Bunk wrote:
> I didn't find any modular usage in the kernel.
And there shouldn't be one either. This is really just for some syscalls,
everything else should use get_super based on a struct block_device. If
there's any caller using this wrongly in out of tree modules they can
be switched to bdget + get_super trivially (fixing their code would be
even better).
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 30 May 2005
> - 13 May 2005
> - 1 May 2005
> - 23 Apr 2005
>
> --- linux-2.6.12-rc2-mm3-full/fs/super.c.old 2005-04-23 02:45:59.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/fs/super.c 2005-04-23 02:46:07.000000000 +0200
> @@ -467,8 +467,6 @@
> return NULL;
> }
>
> -EXPORT_SYMBOL(user_get_super);
> -
> asmlinkage long sys_ustat(unsigned dev, struct ustat __user * ubuf)
> {
> struct super_block *s;
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---end quoted text---
next prev parent reply other threads:[~2005-08-23 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-22 16:20 [RFC: 2.6 patch] fs/super.c: unexport user_get_super Adrian Bunk
2005-08-23 9:54 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-30 20:56 Adrian Bunk
2005-05-13 0:47 Adrian Bunk
2005-05-01 15:42 Adrian Bunk
2005-04-23 4:10 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050823095427.GA4425@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox