From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] namei cleanup
Date: Tue, 23 Aug 2005 21:33:56 +0100 [thread overview]
Message-ID: <20050823203356.GF9322@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <E1E7fMD-0006En-00@dorka.pomaz.szeredi.hu>
On Tue, Aug 23, 2005 at 10:26:53PM +0200, Miklos Szeredi wrote:
Bad names, IMO.
> +static inline void dput_path(struct path *path, struct nameidata *nd)
> +{
> + dput(path->dentry);
> + if (path->mnt != nd->mnt)
> + mntput(path->mnt);
> +}
> +
> +static inline void path_to_nameidata(struct path *path, struct nameidata *nd)
> +{
> + dput(nd->dentry);
> + if (nd->mnt != path->mnt)
> + mntput(nd->mnt);
> + nd->mnt = path->mnt;
> + nd->dentry = path->dentry;
> +}
next prev parent reply other threads:[~2005-08-23 20:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 20:22 [PATCH 0/8] filesystem related cleanups and fixes Miklos Szeredi
2005-08-23 20:24 ` [PATCH 1/8] remove ia_attr_flags Miklos Szeredi
2005-08-23 20:26 ` [PATCH 2/8] namei cleanup Miklos Szeredi
2005-08-23 20:30 ` [PATCH 3/8] use get_fs_struct() in proc Miklos Szeredi
2005-08-23 20:33 ` [PATCH 4/8] fix enum pid_directory_inos in proc/base.c Miklos Szeredi
2005-08-23 20:36 ` [PATCH 5/8] remove duplicated code from proc and ptrace Miklos Szeredi
2005-08-23 20:43 ` [PATCH 6/8] remove duplicated sys_open32() code from 64bit archs Miklos Szeredi
2005-08-23 20:45 ` [PATCH 7/8] cifs_create() fix Miklos Szeredi
2005-08-23 20:47 ` [PATCH 8/8] deprecate open("foo", 3) Miklos Szeredi
2005-08-23 21:44 ` [PATCH 6/8] remove duplicated sys_open32() code from 64bit archs Arnd Bergmann
2005-08-24 8:58 ` Miklos Szeredi
2005-08-24 7:33 ` Christoph Hellwig
2005-08-24 9:00 ` Miklos Szeredi
2005-08-24 9:05 ` Christoph Hellwig
2005-08-23 20:33 ` Al Viro [this message]
2005-08-23 20:50 ` [PATCH 2/8] namei cleanup Miklos Szeredi
2005-08-24 7:32 ` [PATCH 1/8] remove ia_attr_flags Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050823203356.GF9322@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox