From: Arnd Bergmann <arnd@arndb.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] remove duplicated sys_open32() code from 64bit archs
Date: Tue, 23 Aug 2005 23:44:05 +0200 [thread overview]
Message-ID: <200508232344.05666.arnd@arndb.de> (raw)
In-Reply-To: <E1E7fcN-0006IR-00@dorka.pomaz.szeredi.hu>
On Dinsdag 23 August 2005 22:43, Miklos Szeredi wrote:
> 64 bit architectures all implement their own compatibility sys_open(),
> when in fact the difference is simply not forcing the O_LARGEFILE
> flag. So use the a common function instead.
> Index: linux/arch/x86_64/ia32/sys_ia32.c
> ===================================================================
> --- linux.orig/arch/x86_64/ia32/sys_ia32.c 2005-08-23 20:22:33.000000000 +0200
> +++ linux/arch/x86_64/ia32/sys_ia32.c 2005-08-23 21:00:19.000000000 +0200
> @@ -971,28 +971,7 @@ long sys32_kill(int pid, int sig)
>
> asmlinkage long sys32_open(const char __user * filename, int flags, int mode)
> {
> - char * tmp;
> - int fd, error;
Please don't leave the functions inside of the architecture specific code.
The code is common enough to be shared, so just put a new compat_sys_open()
function into fs/compat.c.
I'm also not sure wether s390, mips and/or parisc need to use the
same function instead of the standard sys_open().
Arnd <><
next prev parent reply other threads:[~2005-08-23 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 20:22 [PATCH 0/8] filesystem related cleanups and fixes Miklos Szeredi
2005-08-23 20:24 ` [PATCH 1/8] remove ia_attr_flags Miklos Szeredi
2005-08-23 20:26 ` [PATCH 2/8] namei cleanup Miklos Szeredi
2005-08-23 20:30 ` [PATCH 3/8] use get_fs_struct() in proc Miklos Szeredi
2005-08-23 20:33 ` [PATCH 4/8] fix enum pid_directory_inos in proc/base.c Miklos Szeredi
2005-08-23 20:36 ` [PATCH 5/8] remove duplicated code from proc and ptrace Miklos Szeredi
2005-08-23 20:43 ` [PATCH 6/8] remove duplicated sys_open32() code from 64bit archs Miklos Szeredi
2005-08-23 20:45 ` [PATCH 7/8] cifs_create() fix Miklos Szeredi
2005-08-23 20:47 ` [PATCH 8/8] deprecate open("foo", 3) Miklos Szeredi
2005-08-23 21:44 ` Arnd Bergmann [this message]
2005-08-24 8:58 ` [PATCH 6/8] remove duplicated sys_open32() code from 64bit archs Miklos Szeredi
2005-08-24 7:33 ` Christoph Hellwig
2005-08-24 9:00 ` Miklos Szeredi
2005-08-24 9:05 ` Christoph Hellwig
2005-08-23 20:33 ` [PATCH 2/8] namei cleanup Al Viro
2005-08-23 20:50 ` Miklos Szeredi
2005-08-24 7:32 ` [PATCH 1/8] remove ia_attr_flags Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508232344.05666.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox