From: Nathan Scott <nathans@sgi.com>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk queue io tracing support
Date: Wed, 24 Aug 2005 16:24:59 +1000 [thread overview]
Message-ID: <20050824062459.GD1553@frodo> (raw)
In-Reply-To: <20050823123235.GG16461@suse.de>
Hi Jens,
On Tue, Aug 23, 2005 at 02:32:36PM +0200, Jens Axboe wrote:
> ...
> + t.pid = current->pid;
> ...
> +/*
> + * The trace itself
> + */
> +struct blk_io_trace {
> + u32 magic; /* MAGIC << 8 | version */
> + u32 sequence; /* event number */
> + u64 time; /* in microseconds */
> + u64 sector; /* disk offset */
> + u32 bytes; /* transfer length */
> + u32 action; /* what happened */
> + u16 pid; /* who did it */
Also, this field (pid) should probably be a u32.
cheers.
--
Nathan
next prev parent reply other threads:[~2005-08-24 6:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 12:32 [PATCH] blk queue io tracing support Jens Axboe
2005-08-24 1:03 ` Nathan Scott
2005-08-24 7:08 ` Jens Axboe
2005-08-24 7:19 ` Nathan Scott
2005-08-24 7:25 ` Jens Axboe
2005-08-24 9:28 ` Jens Axboe
2005-08-29 4:53 ` Nathan Scott
2005-08-29 5:57 ` Jens Axboe
2005-08-30 23:43 ` Nathan Scott
2005-08-31 7:31 ` Jens Axboe
2005-08-30 23:48 ` Nathan Scott
2005-08-30 23:58 ` Nathan Scott
2005-08-31 4:19 ` Tom Zanussi
2005-08-31 4:33 ` Nathan Scott
2005-08-31 4:53 ` Nathan Scott
2005-08-31 4:55 ` Tom Zanussi
2005-08-31 7:33 ` Jens Axboe
2005-09-02 11:20 ` Jens Axboe
2005-08-24 6:24 ` Nathan Scott [this message]
2005-08-24 7:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050824062459.GD1553@frodo \
--to=nathans@sgi.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox