Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

[Al Viro <viro@parcelfarce.linux.theplanet.co.uk>]

On Wed, Aug 24, 2005 at 05:31:34PM +0100, Al Viro wrote:
> On Wed, Aug 24, 2005 at 09:22:27AM -0700, Roland Dreier wrote:
> >     Al> infiniband uses PCI helpers all over the place (including the
> >     Al> core parts) and won't build without PCI.
> > 
> > I don't think this is the right fix.  The only PCI helpers used in
> > code that is enabled with CONFIG_PCI=n are pci_unmap_addr_set() and
> > pci_unmap_addr().  And they're only used because no one has added
> > dma_unmap_addr_set() and dma_unmap_addr() -- the core code is properly
> > using the general dma_xxx API wherever possible.
> > 
> > There actually is non-PCI InfiniBand hardware coming, so we'll have to
> > fix this properly at some point.
> 
> I'm all for it and removing BROKEN from Kconfig when fixes happen is
> obviously not a problem at all ;-)

PS: note that it's not
	depends on PCI
it's
	depends on PCI || BROKEN
which
	a) documents that something is wrong
	b) leaves all setups usable now intact
	c) prevents broken setups from being picked.

I certainly agree that proper fix is to switch to dma_... - no arguments here.
BTW, another dubious thing is use of DECLARE_PCI_UNMAP_ADDR() in infiniband
core - it's fine in PCI drivers (which is how it's used elsewhere), but not
in generic data structures.