From: Adrian Bunk <bunk@stusta.de>
To: "Tomita, Haruo" <haruo.tomita@toshiba.co.jp>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: libata-dev queue updated
Date: Fri, 26 Aug 2005 02:16:28 +0200 [thread overview]
Message-ID: <20050826001628.GF6471@stusta.de> (raw)
In-Reply-To: <BF571719A4041A478005EF3F08EA6DF001617B39@pcsmail03.pcs.pc.ome.toshiba.co.jp>
On Fri, Aug 26, 2005 at 09:04:37AM +0900, Tomita, Haruo wrote:
> On Thursday, August 25, 2005 8:02 PM (JST), Adrian Bunk wrote:
>
> > > 2.6.13- rc7-libata1.patch.bz2 was used.
> > > A combined mode of ata_piix seems not to work.
> > > Is the following patches correct?
> > >
> > > diff -urN linux-2.6.13-rc7.orig/drivers/scsi/Kconfig
> > linux-2.6.13-rc7/drivers/scsi/Kconfig
> > > --- linux-2.6.13-rc7.orig/drivers/scsi/Kconfig
> > 2005-08-25 13:44:33.000000000 +0900
> > > +++ linux-2.6.13-rc7/drivers/scsi/Kconfig 2005-08-25
> > 14:33:38.000000000 +0900
> > > @@ -424,7 +424,7 @@
> > > source "drivers/scsi/megaraid/Kconfig.megaraid"
> > >
> > > config SCSI_SATA
> > > - tristate "Serial ATA (SATA) support"
> > > + bool "Serial ATA (SATA) support"
> > > depends on SCSI
> > > help
> > > This driver family supports Serial ATA host controllers
> >
> > No, this bug reintroduces a problem with SCSI=m.
>
> Please explain this bug in detail.
Assuming your patch is applied:
With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
-> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
-> SCSI_ATA_ADMA and libata are built statically but
scsi/built-in.o is not linked into the kernel,
SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
libata)
> > Which problem do you face?
> > And how did this change alone fix it for you?
>
> I am using Intel 82801EB SATA controller.
> 2.6.13-rc7-libata1.patch.bz2 worked as PATA when 82801EB was used in a combined mode.
> Does quirk_intel_ide_combined() work effectively?
I do still not see how your proposed patch would have _any_ influence on
your problem.
> Thanks,
> Haruo
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-08-26 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 0:04 libata-dev queue updated Tomita, Haruo
2005-08-26 0:16 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-27 13:54 Jeff Garzik
2005-08-26 8:41 Tomita, Haruo
2005-08-25 6:56 Tomita, Haruo
2005-08-25 11:02 ` Adrian Bunk
2005-08-24 6:56 Jeff Garzik
2005-01-07 7:10 Jeff Garzik
2004-12-03 15:01 Dieter Stueken
2004-12-04 6:15 ` Brad Campbell
2004-12-02 8:29 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050826001628.GF6471@stusta.de \
--to=bunk@stusta.de \
--cc=haruo.tomita@toshiba.co.jp \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox