From: Jens Axboe <axboe@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move tasklist walk from cfq-iosched to elevator.c
Date: Fri, 26 Aug 2005 15:45:10 +0200 [thread overview]
Message-ID: <20050826134509.GF4018@suse.de> (raw)
In-Reply-To: <20050826114924.GA28166@lst.de>
On Fri, Aug 26 2005, Christoph Hellwig wrote:
> We're trying to get rid of as much as possible tasklist walks, or at
> least moving them to core code. This patch falls into the second
> category.
>
> Instead of walking the tasklist in cfq-iosched move that into
> elv_unregister. The added benefit is that with this change the as
> ioscheduler might be might unloadable more easily aswell.
>
> The new code uses read_lock instead of read_lock_irq because the
> tasklist_lock only needs irq disabling for writers.
Looks innocent enough, fine with me. 'as' will need additional work to
be unloadable, but it wont break anything since it's running with an
elevated module count right now anyways.
--
Jens Axboe
next prev parent reply other threads:[~2005-08-26 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-26 11:49 [PATCH] move tasklist walk from cfq-iosched to elevator.c Christoph Hellwig
2005-08-26 13:45 ` Jens Axboe [this message]
2005-09-19 13:16 ` Christoph Hellwig
2005-09-19 13:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050826134509.GF4018@suse.de \
--to=axboe@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox