Re: [PATCH 5/5] Remove unnecesary capability hooks in rootplug.

Chris Wright
2005-08-25T21:13:15Z

* serue@us.ibm.com (serue@us.ibm.com) wrote:
> @@ -1527,7 +1533,8 @@ static int selinux_vm_enough_memory(long
> int rc, cap_sys_admin = 0;
> struct task_security_struct *tsec = current->security;
>
> - rc = secondary_ops->capable(current, CAP_SYS_ADMIN);
> + rc = secondary_ops->capable ?
> + secondary_ops->capable(current, CAP_SYS_ADMIN) : 0;

I don't think this really makes sense. It says the default secondary
thinks you have the capablity. Safe since SELinux double checks, but
not really accurate.

thanks,
-chris