The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: linux-kernel@vger.kernel.org, stable@kernel.org,
	dbrownell@users.sourceforge.net
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
	David Brownell <david-b@pacbell.net>,
	Chris Wright <chrisw@osdl.org>
Subject: [PATCH 5/7] [PATCH] fix gl_skb/skb type error in genelink driver in usbnet
Date: Fri, 26 Aug 2005 12:18:00 -0700	[thread overview]
Message-ID: <20050826191927.323489000@localhost.localdomain> (raw)
In-Reply-To: 20050826191755.052951000@localhost.localdomain

[-- Attachment #1: genelink-usbnet-skb-typo.patch --]
[-- Type: text/plain, Size: 890 bytes --]

-stable review patch.  If anyone has any  objections, please let us know.
------------------

I think there is a type error when port genelink driver to 2.6..
With this error, a linux host will panic when it link with a windows
host.

Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Chris Wright <chrisw@osdl.org>
---
 drivers/usb/net/usbnet.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.12.y/drivers/usb/net/usbnet.c
===================================================================
--- linux-2.6.12.y.orig/drivers/usb/net/usbnet.c
+++ linux-2.6.12.y/drivers/usb/net/usbnet.c
@@ -1922,7 +1922,7 @@ static int genelink_rx_fixup (struct usb
 
 			// copy the packet data to the new skb
 			memcpy(skb_put(gl_skb, size), packet->packet_data, size);
-			skb_return (dev, skb);
+			skb_return (dev, gl_skb);
 		}
 
 		// advance to the next packet

--

  parent reply	other threads:[~2005-08-26 19:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-26 19:17 [PATCH 0/7] -stable review Chris Wright
2005-08-26 19:17 ` [PATCH 1/7] [IPSEC] Restrict socket policy loading to CAP_NET_ADMIN - CAN-2005-2555 Chris Wright
2005-08-26 19:17 ` [PATCH 2/7] [PATCH] NPTL signal delivery deadlock fix Chris Wright
2005-08-26 19:17 ` [PATCH 3/7] [PATCH] Revert unnecessary zlib_inflate/inftrees.c fix Chris Wright
2005-08-26 19:17 ` [PATCH 4/7] [IPV4]: Fix DST leak in icmp_push_reply() Chris Wright
2005-08-26 19:18 ` Chris Wright [this message]
2005-08-26 19:18 ` [PATCH 6/7] [PATCH] sg.c: fix a memory leak in devices seq_file implementation (2nd) Chris Wright
2005-08-27  2:19   ` James Bottomley
2005-09-25  3:50     ` Douglas Gilbert
2005-08-26 19:18 ` [PATCH 7/7] [IPV6]: Fix SKB leak in ip6_input_finish() Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050826191927.323489000@localhost.localdomain \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=chuckw@quantumlinux.com \
    --cc=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox