From: Pavel Machek <pavel@ucw.cz>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Meelis Roos <mroos@linux.ee>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Masoud Sharbiani <masouds@masoud.ir>,
Len Brown <len.brown@intel.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] [ACPI] acpi_shutdown: Only prepare for power off on power_off
Date: Sat, 27 Aug 2005 22:48:28 +0200 [thread overview]
Message-ID: <20050827204828.GA1971@elf.ucw.cz> (raw)
In-Reply-To: <m1acj3rwjl.fsf@ebiederm.dsl.xmission.com>
Hi!
> >> When acpi_sleep_prepare was moved into a shutdown method we
> >> started calling it for all shutdowns. It appears this triggers
> >> some systems to power off on reboot. Avoid this by only calling
> >> acpi_sleep_prepare if we are going to power off the system.
> >
> > Are you sure that system_state is correctly set at this point? There are
> > quite a few ways that lead to this...
>
> - It is an error if system_state is not set properly.
>
> - Do to my earlier cleanups there are only 4 functions
> that call device_shutdown they are:
> kernel_restart(), kernel_kexec(), kernel_halt(), kernel_power_off()
>
> And those four all set system_state correctly.
>
> If you can find another path that calls this incorrectly I would be happy
> to fix it. But my grep through the kernel doesn't reveal any other
> callers.
Ok, thanks for analysis!
Pavel
--
if you have sharp zaurus hardware you don't need... you know my address
next prev parent reply other threads:[~2005-08-27 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-20 18:41 2.6.13-rc6: halt instead of reboot Meelis Roos
2005-08-22 5:00 ` Eric W. Biederman
2005-08-22 8:53 ` Meelis Roos
2005-08-22 9:34 ` Eric W. Biederman
2005-08-24 19:55 ` Meelis Roos
2005-08-25 3:32 ` Eric W. Biederman
2005-08-25 21:49 ` Meelis Roos
2005-08-26 5:05 ` Meelis Roos
2005-08-26 5:52 ` Eric W. Biederman
2005-08-26 18:45 ` Meelis Roos
2005-08-27 6:56 ` [PATCH] [ACPI] acpi_shutdown: Only prepare for power off on power_off Eric W. Biederman
2005-08-27 11:58 ` Pavel Machek
2005-08-27 19:48 ` Eric W. Biederman
2005-08-27 20:48 ` Pavel Machek [this message]
2005-08-22 15:52 ` 2.6.13-rc6: halt instead of reboot Masoud Sharbiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050827204828.GA1971@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masouds@masoud.ir \
--cc=mroos@linux.ee \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox