public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Trailing comments in broken-out series file break quilt
Date: Mon, 29 Aug 2005 19:15:16 -0700	[thread overview]
Message-ID: <20050829191516.4e5d9e0b.pj@sgi.com> (raw)

Apparently Andrews patch tools allow trailing comments on active lines
in the series file, as in these lines culled from the series file for
2.6.13-rc6-mm2:

    e1000-numa-aware-allocation-of-descriptors-v2.patch # hold
    nfs-nfs3-page-null-fill-in-a-short-read-situation.patch # wait
    sched-implement-nice-support-across-physical-cpus-on-smp.patch # con
    sched-change_prio_bias_only_if_queued.patch # con
    sched-account_rt_tasks_in_prio_bias.patch # con
    sched-smp-nice-bias-busy-queues-on-idle-rebalance.patch # con
    sched-correct_smp_nice_bias.patch # con
    md-fix-rh_dec-rh_inc-race-in-dm-raid1c.patch # wait

However the quilt command passes these additional terms to the patch
command as additional arguments, confusing the heck out of patch,
and generating an error message that confused the heck out of me.

Question - should I be asking Andrew not to comment this way, or
should I be asking quilt to recognize a comment convention here?

If we choose the second alternative, then the following change to
the file /usr/local/share/quilt/scripts/patchfns might to the trick:

--- /tmp/q/patchfns.1	2005-08-29 19:11:24.000000000 -0700
+++ /tmp/q/patchfns.2	2005-08-29 19:11:31.000000000 -0700
@@ -108,8 +108,8 @@ patch_args()
 	then
 		/bin/gawk '
 		$1 == "'"$patch"'" \
-			{ if (NF >= 2)
-				for (i=2; i <= NF; i++)
+			{ if (NF >= 2 && $2 != "#")
+				for (i=2; i <= NF && $i != "#"; i++)
 					print $i
 			  else
 				print "-p1" ;

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

             reply	other threads:[~2005-08-30  2:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30  2:15 Paul Jackson [this message]
2005-08-30  3:03 ` Trailing comments in broken-out series file break quilt Andrew Morton
2005-08-30  8:03   ` Paul Jackson
2005-08-30 19:06 ` Jean Delvare
2005-08-31  1:39   ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050829191516.4e5d9e0b.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox