From: Karsten Keil <kkeil@suse.de>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Pfeiffer <pfeiffer@pds.de>,
isdn4linux@listserv.isdn4linux.de,
Kai Germaschewski <kai.germaschewski@gmx.de>
Subject: Re: [PATCH] isdn_v110 warning fix
Date: Tue, 30 Aug 2005 12:51:04 +0200 [thread overview]
Message-ID: <20050830105104.GA6918@pingi3.kke.suse.de> (raw)
In-Reply-To: <200508300105.44247.jesper.juhl@gmail.com>
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
>
This is OK. Even if the codepath is never executed in a way that ret might
be used uninitialized it does not harm to set ret = 0.
Warning fix :
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized in this function
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Karsten Keil <kkeil@suse.de>
---
drivers/isdn/i4l/isdn_v110.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c 2005-08-29 01:41:01.000000000 +0200
+++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c 2005-08-30 00:59:34.000000000 +0200
@@ -516,11 +516,11 @@
}
int
-isdn_v110_stat_callback(int idx, isdn_ctrl * c)
+isdn_v110_stat_callback(int idx, isdn_ctrl *c)
{
isdn_v110_stream *v = NULL;
int i;
- int ret;
+ int ret = 0;
if (idx < 0)
return 0;
next prev parent reply other threads:[~2005-08-30 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-29 23:05 [PATCH] isdn_v110 warning fix Jesper Juhl
2005-08-30 8:20 ` Alexey Dobriyan
2005-08-30 8:42 ` Thomas Pfeiffer
2005-08-30 11:25 ` Jesper Juhl
2005-08-30 10:51 ` Karsten Keil [this message]
2005-08-30 13:47 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050830105104.GA6918@pingi3.kke.suse.de \
--to=kkeil@suse.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=jesper.juhl@gmail.com \
--cc=kai.germaschewski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pfeiffer@pds.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox