From: Adrian Bunk <bunk@stusta.de>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
Date: Tue, 30 Aug 2005 18:29:44 +0200 [thread overview]
Message-ID: <20050830162944.GB7071@stusta.de> (raw)
In-Reply-To: <20050830161814.GA31940@suse.de>
On Tue, Aug 30, 2005 at 06:18:14PM +0200, Olaf Hering wrote:
> On Tue, Aug 30, Adrian Bunk wrote:
>
> > Currently, using an undeclared function gives a compile warning, but it
> > can lead to a link or even a runtime error.
> >
> > With -Werror-implicit-function-declaration, we are getting an immediate
> > compile error instead.
>
> You have to fix CONFIG_SWAP=n as well.
>
> http://lkml.org/lkml/2005/8/6/72
I don't see any such warning in the 2.6.13 sparc build at Jan's
crosscompile page [1], and all my patch does is to turn a warning into
an error.
If a #define is using it before the header with the prototype get's
#include'd that's no problem as long as the prototype is available when
the #define is _used_.
I'm not saying that there aren't cases this patch will break (and my
patch shouldn't go into 2.6.14), but your example doesn't seem to cause
problems.
cu
Adrian
[1] http://l4x.org/k/?d=6676
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-08-30 16:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 14:54 [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS Adrian Bunk
2005-08-30 16:18 ` Olaf Hering
2005-08-30 16:29 ` Adrian Bunk [this message]
2005-08-30 16:38 ` Olaf Hering
2005-08-30 16:48 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-07-07 17:10 Luck, Tony
2006-07-06 16:37 Adrian Bunk
2006-07-06 18:05 ` Jesper Juhl
2006-07-06 18:20 ` Dave Jones
2006-07-07 3:36 ` Sam Ravnborg
2006-07-07 5:02 ` Valdis.Kletnieks
2006-07-07 6:42 ` Sam Ravnborg
2006-07-07 7:49 ` Adrian Bunk
2006-07-07 7:53 ` Milton Miller
2006-07-07 7:18 ` Adrian Bunk
2006-07-07 7:49 ` Heiko Carstens
2006-07-07 9:33 ` Sam Ravnborg
2006-06-28 16:54 Adrian Bunk
2005-11-23 22:34 Adrian Bunk
2005-11-23 23:09 ` Andrew Morton
2005-11-23 23:38 ` Adrian Bunk
2005-11-23 23:50 ` Andrew Morton
2005-11-24 0:13 ` Adrian Bunk
2005-11-07 20:03 Adrian Bunk
2005-11-10 12:28 ` Andrew Morton
2005-11-11 2:12 ` Adrian Bunk
2005-11-11 2:24 ` Andrew Morton
2005-11-11 3:45 ` Randy.Dunlap
2005-11-11 20:18 ` Adrian Bunk
2005-11-11 20:20 ` Adrian Bunk
2005-11-11 20:36 ` Adrian Bunk
2005-11-11 21:24 ` Andrew Morton
2005-11-11 23:34 ` Sam Ravnborg
2005-11-12 0:33 ` Adrian Bunk
2005-07-30 16:52 Adrian Bunk
2005-07-30 18:08 ` Andrew Morton
2005-07-30 19:44 ` Adrian Bunk
2005-07-30 18:52 ` Sam Ravnborg
2005-07-30 18:59 ` Christoph Hellwig
2005-07-30 19:40 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050830162944.GB7071@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox