From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932543AbVIAGsb (ORCPT ); Thu, 1 Sep 2005 02:48:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932544AbVIAGsb (ORCPT ); Thu, 1 Sep 2005 02:48:31 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:47308 "EHLO mx3.mail.elte.hu") by vger.kernel.org with ESMTP id S932543AbVIAGsa (ORCPT ); Thu, 1 Sep 2005 02:48:30 -0400 Date: Thu, 1 Sep 2005 08:49:03 +0200 From: Ingo Molnar To: Daniel Walker Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org Subject: Re: PREEMPT_RT with e1000 Message-ID: <20050901064902.GA5179@elte.hu> References: <1125518602.15034.3.camel@dhcp153.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1125518602.15034.3.camel@dhcp153.mvista.com> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=AWL autolearn=disabled SpamAssassin version=3.0.3 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Walker wrote: > It looks like Gigabit Ethernet is still having some problems. This is > with the e1000 driver. If I remove all the qdisc_restart changes it > starts to work the warning below goes away, but it has > smp_processor_id warnings. hmmm. The thing to watch out for there is dev->xmit_lock_owner - it's a "spin lock does not preempt" assumption that is open-coded. What the qdisc_restart changes do is to remove this assumption. Perhaps it would be enough to just keep the trylock logic, and to mute the xmit_lock_owner logic. Ingo